rapid7/metasploit-framework

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        elif decodedTGS['ticket']['enc-part']['etype'] == constants.EncryptionTypes.aes128_cts_hmac_sha1_96.value:
            entry = '$krb5tgs$%d$%s$%s$*%s*$%s$%s' % (
                constants.EncryptionTypes.aes128_cts_hmac_sha1_96.value, username, decodedTGS['ticket']['realm'],
                spn.replace(':', '~'),
                hexlify(decodedTGS['ticket']['enc-part']['cipher'][-12:].asOctets()).decode(),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        elif decodedTGS['ticket']['enc-part']['etype'] == constants.EncryptionTypes.aes256_cts_hmac_sha1_96.value:
            entry = '$krb5tgs$%d$%s$%s$*%s*$%s$%s' % (
                constants.EncryptionTypes.aes256_cts_hmac_sha1_96.value, username, decodedTGS['ticket']['realm'],
                spn.replace(':', '~'),
                hexlify(decodedTGS['ticket']['enc-part']['cipher'][-12:].asOctets()).decode(),

• Read up
  Read up

Method generate has 285 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def generate(_opts = {})

    target_uri = datastore['URL'] || ""
    filename = datastore['EXE'] || ""
    proto = "https"

File client.rb has 639 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'rex/encoder/ndr'
require 'recog'

module Msf
  module Exploit::Remote::SMB

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def make_pdf(js)
    xref = []
    eol = "\n"
    endobj = "endobj" << eol

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def make_pdf(js)
    xref = []
    eol = "\n"
    endobj = "endobj" << eol

• Read up
  Read up

File android.rb has 637 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'rex/post/meterpreter'
require 'rex/post/meterpreter/extensions/android/command_ids'
require 'date'

module Rex

File uds.rb has 636 lines of code (exceeds 250 allowed). Consider refactoring.

Open

module Msf
class Post
module Hardware
module Automotive

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if decodedTGS['ticket']['enc-part']['etype'] == constants.EncryptionTypes.rc4_hmac.value:
            entry = '$krb5tgs$%d$*%s$%s$%s*$%s$%s' % (
                constants.EncryptionTypes.rc4_hmac.value, username, decodedTGS['ticket']['realm'],
                spn.replace(':', '~'),
                hexlify(decodedTGS['ticket']['enc-part']['cipher'][:16].asOctets()).decode(),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        elif decodedTGS['ticket']['enc-part']['etype'] == constants.EncryptionTypes.des_cbc_md5.value:
            entry = '$krb5tgs$%d$*%s$%s$%s*$%s$%s' % (
                constants.EncryptionTypes.des_cbc_md5.value, username, decodedTGS['ticket']['realm'],
                spn.replace(':', '~'),
                hexlify(decodedTGS['ticket']['enc-part']['cipher'][:16].asOctets()).decode(),

• Read up
  Read up

Method on_request_uri has 280 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def on_request_uri(cli, request)
    print_status("Request from #{request['User-Agent']}")
    if request.uri =~ %r{/loader32$}
      print_good("armle target is vulnerable.")
      local_file = File.join( Msf::Config.data_directory, "exploits", "CVE-2016-4655", "exploit32" )

Class EXE has 74 methods (exceeds 20 allowed). Consider refactoring.

Open

class EXE

require 'rex'
require 'rex/peparsey'
require 'rex/pescan'

Class Modules has 74 methods (exceeds 20 allowed). Consider refactoring.

Open

        class Modules

          include Msf::Ui::Console::CommandDispatcher
          include Msf::Ui::Console::CommandDispatcher::Common

File packet.rb has 624 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'openssl'
require 'rex/post/meterpreter/command_mapper'

module Rex
module Post

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if self.__noOutput is False:
            smbConnection = SMBConnection(addr, addr)
            if self.__doKerberos is False:
                smbConnection.login(self.__username, self.__password, self.__domain, self.__lmhash, self.__nthash)
            else:

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            try:
                smbConnection = SMBConnection(addr, addr)
                if self.__doKerberos is False:
                    smbConnection.login(self.__username, self.__password, self.__domain, self.__lmhash, self.__nthash)
                else:

• Read up
  Read up

File oraenum.rb has 621 lines of code (exceeds 250 allowed). Consider refactoring.

Open

class MetasploitModule < Msf::Auxiliary
  include Msf::Auxiliary::Report
  include Msf::Exploit::ORACLE

  def initialize(info = {})

Method exploit has 272 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def exploit
    if !datastore['ForceExploit'] && is_root?
      fail_with(Failure::BadConfig, 'Session already has root privileges. Set ForceExploit to override.')
    end

File whatsupgold_credential_dump.rb has 614 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'metasploit/framework/credential_collection'

class MetasploitModule < Msf::Post
  include Msf::Post::Common
  include Msf::Post::File

Method apply_prepends has 267 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def apply_prepends(buf)
    pre = ''
    app = ''

    test_arch = [ *(self.arch) ]