Showing 85 of 110 total issues
Method build_details_of_interview_section
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.build_details_of_interview_section
details_of_interview_fields = [
Field.new('name' => '6_name',
'type' => 'text_field',
'display_name_all' => 'Name'
Method authenticate_user
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def authenticate_user
user = User.find_by_user_name(@user_name)
if user && user.authenticate(@password)
mobile_login_history = user.mobile_login_history.first
imei = mobile_login_history.nil? ? '' : mobile_login_history['imei']
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method return_partial_hash
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def return_partial_hash(change, field, history, model = nil)
if field == 'photo_keys'
return {:partial => 'shared/histories/photo_history_change',
:locals => {
:new_photos => change['added'],
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method mark_or_unmark_as_reunited
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def mark_or_unmark_as_reunited(reunited)
without_updating_matches do
Enquiry.skip_callback(:save, :after, :find_matching_children)
self['reunited'] = reunited
save!
Method update
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def update
respond_to do |format|
format.json do
params[:child] = JSON.parse(params[:child]) if params[:child].is_a?(String)
child = update_child_from params
Method update
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def update
authorize! :disable, @user if params[:user].include?(:disabled)
authorize! :update, @user if params[:user].except(:disabled).present?
params[:verify] = !@user.verified?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method sync_unverified
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def sync_unverified
params[:child] = JSON.parse(params[:child]) if params[:child].is_a?(String)
params[:child][:photo] = params[:current_photo_key] unless params[:current_photo_key].nil?
if params[:child][:_id]
child = Child.get(params[:child][:_id])
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update_from
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def update_from(properties)
attributes_to_update = {}
properties.each_pair do |name, value|
if value.instance_of?(HashWithIndifferentAccess) || value.instance_of?(ActionController::Parameters)
attributes_to_update[name] = self[name] if attributes_to_update[name].nil?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method generate_html
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def generate_html(criteria, all_fields)
field = all_fields.find { |f| f.name == criteria[:field] }
return '' unless field.present?
html = ''
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method index
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def index
authorize! :index, Enquiry
@page_name = t('home.view_records')
@filter = params[:filter] || nil
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method initialize_child_permissions
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def initialize_child_permissions(user)
if user.has_permission?(Permission::CHILDREN[:register])
can [:create], Child
can [:read], Child do |child|
child.created_by == user.user_name
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method flag_saved_embedded_properties
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def flag_saved_embedded_properties
casted_properties = properties_with_values.select { |_property, value| value.respond_to?(:casted_by) && value.respond_to?(:casted_by_property) }
casted_properties.each do |_property, value|
if value.instance_of?(CouchRest::Model::CastedArray)
value.each do |item|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Consider simplifying this complex logical expression. Open
return true if age.nil? || age.blank? || !age.number? || (age =~ /^\d{1,2}(\.\d)?$/ && age.to_f > 0 && age.to_f < 100)
Method update_properties_with_user_name
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def update_properties_with_user_name(user_name, new_photo, photo_names, new_audio, properties)
Method initialize
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def initialize(base_behavior, action, subject, conditions, block)
Method from_file
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def self.from_file(file, content_type, name_prefix = 'file', name_suffix = '', child = nil)
Method delete_photos
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def delete_photos(photo_names)
return unless photo_names
photo_names = photo_names.keys if photo_names.is_a? Hash
photo_names.map { |x| related_keys(x) }.flatten.each do |key|
photo_key_index = self['photo_keys'].find_index(key)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method format_field_for_export
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def format_field_for_export(field, value, child = nil)
return '' if value.blank?
return value.join(', ') if field.type == Field::CHECK_BOXES
if child
# TODO: rubocop:disable CommentAnnotation
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method sanitize_params
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def sanitize_params
super :child
unless (params[:updated_after]).nil?
DateTime.parse params[:updated_after]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def update
@field = fetch_field params[:id]
@field.attributes = params[:field] unless params[:field].nil?
@form_section.save
@show_add_field = {:show_add_field => true}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"