Sign upLogin

raveljs/ravel-mysql-provider

View on GitHub
Star
lib/ravel-mysql-provider.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function exitTransaction has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  exitTransaction (connection, shouldCommit) {
    const self = this;
    const log = this.$log;
    return new Promise((resolve, reject) => {
      if (!shouldCommit) {
Severity: Minor
Found in lib/ravel-mysql-provider.js - About 1 hr to fix

    Function getTransactionConnection has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      getTransactionConnection () {
    const self = this;
    return new Promise((resolve, reject) => {
      this.pool.getConnection(function (connectionErr, connection) {
        if (connectionErr) {
    Severity: Minor
    Found in lib/ravel-mysql-provider.js - About 1 hr to fix

      Function release has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        release (connection, err) {
    // if we know this is a fatal error, don't return the connection to the pool
    if (err && err.fatal) {
      this.$log.trace('Destroying fatally-errored connection.');
      try { connection.destroy(); } catch (e) { /* don't worry about double destroys for now */ }
      Severity: Minor
      Found in lib/ravel-mysql-provider.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status