Showing 23 of 79 total issues
Avoid too many return
statements within this function. Open
Open
return false
Method createUser
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
public User createUser(User user, Set<UserRole> userRoles) {
User localUser = userDao.findByUsername(user.getUsername());
if (localUser != null) {
LOG.info("User with username {} already exist. Nothing will be done. ", user.getUsername());
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method signupPost
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
@RequestMapping(value = AppConstants.HOME_SIGNUP, method = RequestMethod.POST)
public String signupPost(@ModelAttribute("user") User user, Model model) {
L.debug("57 : Start : HomeController.signupPost(...)");
if(userService.checkUserExists(user.getUsername(), user.getEmail())) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"