Sign upLogin

raychenon/gray-sky-weather

View on GitHub
Star

Showing 4 of 10 total issues

Method onViewCreated has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
        super.onViewCreated(view, savedInstanceState)

        val errorMessage =
            { "since Koin DI is done at run time instead of compile time, better to check" }
Severity: Minor
Found in app/src/main/java/io/betterapps/graysky/ui/weatherforecast/WeatherForecastFragment.kt - About 1 hr to fix

    Method onActivityResult has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) {

        if (requestCode == AUTOCOMPLETE_REQUEST_CODE) {
            when (resultCode) {
                Activity.RESULT_OK -> {
    Severity: Minor
    Found in app/src/main/java/io/betterapps/graysky/MainActivity.kt - About 1 hr to fix

      Method newInstance has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

                  name: String?,
            latitude: Double,
            longitude: Double,
            distanceFromUserLocation: Double,
            position: Int
      Severity: Minor
      Found in app/src/main/java/io/betterapps/graysky/ui/weatherforecast/WeatherForecastFragment.kt - About 35 mins to fix

        Method onViewCreated has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
        Open

            override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
        super.onViewCreated(view, savedInstanceState)

        val errorMessage =
            { "since Koin DI is done at run time instead of compile time, better to check" }
        Severity: Minor
        Found in app/src/main/java/io/betterapps/graysky/ui/weatherforecast/WeatherForecastFragment.kt - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language