Sign upLogin

rbutrcom/rbutr-browser-extension

View on GitHub
Star
src/background.js

Summary

Maintainability
F
4 days
Test Coverage

Function Rbutr has 281 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const Rbutr = () => {

    'use strict';

    let properties = {
Severity: Major
Found in src/background.js - About 1 day to fix

    Function Rbutr has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
    Open

    const Rbutr = () => {

    'use strict';

    let properties = {
    Severity: Minor
    Found in src/background.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File background.js has 364 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*!
 * Rbutr Browser Extension v0.12.0
 * https://github.com/rbutrcom/rbutr-browser-extension
 *
 * Copyright 2012-2017 The Rbutr Community
    Severity: Minor
    Found in src/background.js - About 4 hrs to fix

      Function getRebuttals has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const getRebuttals = (tabId, url) => {

        setProp('rebuttals', tabId, null);
        let canVote = false;
        let recordedClick = getRecordedClickByToUrl(getProp('canonicalUrls', tabId));
      Severity: Minor
      Found in src/background.js - About 1 hr to fix

        Function submitRebuttals has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            const submitRebuttals = (tabId) => {

        let sourcePageTitles = [];
        let rebuttalPageTitles = [];
        let canonicalSourcePages = [];
        Severity: Minor
        Found in src/background.js - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                          return true;
          Severity: Major
          Found in src/background.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return true;
            Severity: Major
            Found in src/background.js - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      api.submitRebuttalRequest(submitParameters, (success, result) => {
            if (success === true) {
                popupPort.postMessage({response: 'submitRebuttalRequest', status: 'success', result: result});
            } else {
                popupPort.postMessage({response: 'submitRebuttalRequest', status: 'error', result: `Rebuttal request could not be submitted: ${result}`});
              Severity: Major
              Found in src/background.js and 1 other location - About 3 hrs to fix
              src/background.js on lines 429..435

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 97.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      api.submitIdea(submitParameters, (success, result) => {
            if (success === true) {
                popupPort.postMessage({response: 'submitIdea', status: 'success', result: result});
            } else {
                popupPort.postMessage({response: 'submitIdea', status: 'error', result: `Idea could not be submitted: ${result}`});
              Severity: Major
              Found in src/background.js and 1 other location - About 3 hrs to fix
              src/background.js on lines 456..462

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 97.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      for (let j = 0; j < getPropLen('sourceUrls'); j++) {
            sourcePageTitles[j] = getProp('pageTitle', getProp('sourceUrls', j));
            canonicalSourcePages[j] = getProp('urlIsCanonical', getProp('sourceUrls', j));
        }
              Severity: Major
              Found in src/background.js and 1 other location - About 1 hr to fix
              src/background.js on lines 378..381

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 69.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      for (let i = 0; i < getPropLen('rebuttalUrls'); i++) {
            rebuttalPageTitles[i] = getProp('pageTitle', getProp('rebuttalUrls', i));
            canonicalRebuttalPages[i] = getProp('urlIsCanonical', getProp('rebuttalUrls', i));
        }
              Severity: Major
              Found in src/background.js and 1 other location - About 1 hr to fix
              src/background.js on lines 383..386

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 69.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      for (let j = 0; j < getPropLen('rebuttalUrls'); j++) {
            if (getProp('rebuttalUrls', j) === url) {
                return true;
            }
        }
              Severity: Minor
              Found in src/background.js and 1 other location - About 35 mins to fix
              src/background.js on lines 171..175

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      for (let i = 0; i < getPropLen('sourceUrls'); i++) {
            if (getProp('sourceUrls', i) === url) {
                return true;
            }
        }
              Severity: Minor
              Found in src/background.js and 1 other location - About 35 mins to fix
              src/background.js on lines 176..180

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status