Sign upLogin

reactjs/redux

View on GitHub
Star

Showing 33 of 116 total issues

Function miniKindOf has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function miniKindOf(val: any): string {
  if (val === void 0) return 'undefined'
  if (val === null) return 'null'

  const type = typeof val
Severity: Minor
Found in src/utils/kindOf.ts - About 1 hr to fix

    Function setup has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function setup(id, counter, childIds, parentId) {
  const actions = {
    increment: jest.fn(),
    removeChild: jest.fn(),
    deleteNode: jest.fn(),
    Severity: Minor
    Found in examples/tree-view/src/containers/Node.spec.js - About 1 hr to fix

      Function setup has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const setup = () => {
  const props = {
    filteredTodos: [
      {
        text: 'Use Redux',
      Severity: Minor
      Found in examples/todomvc/src/components/TodoList.spec.js - About 1 hr to fix

        Function render has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          render() {
    const { counter, parentId, childIds } = this.props
    return (
      <div>
        Counter: {counter}{' '}
        Severity: Minor
        Found in examples/tree-view/src/containers/Node.js - About 1 hr to fix

          Function assertReducerShape has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function assertReducerShape(reducers: {
  [key: string]: Reducer<any, any, any>
}) {
  Object.keys(reducers).forEach(key => {
    const reducer = reducers[key]
          Severity: Minor
          Found in src/combineReducers.ts - About 1 hr to fix

            Function getUnexpectedStateShapeWarningMessage has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            function getUnexpectedStateShapeWarningMessage(
  inputState: object,
  reducers: { [key: string]: Reducer<any, any, any> },
  action: Action,
  unexpectedKeyCache: { [key: string]: true }
            Severity: Minor
            Found in src/combineReducers.ts - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function render has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              render() {
    const { selectedSubreddit, posts, isFetching, lastUpdated } = this.props
    const isEmpty = posts.length === 0
    return (
      <div>
            Severity: Minor
            Found in examples/async/src/containers/App.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function miniKindOf has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            export function miniKindOf(val: any): string {
  if (val === void 0) return 'undefined'
  if (val === null) return 'null'

  const type = typeof val
            Severity: Minor
            Found in src/utils/kindOf.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

              return Object.prototype.toString
    .call(val)
    .slice(8, -1)
    .toLowerCase()
    .replace(/\s/g, '')
            Severity: Major
            Found in src/utils/kindOf.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                if (isDate(val)) return 'date'
              Severity: Major
              Found in src/utils/kindOf.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                  if (isError(val)) return 'error'
                Severity: Major
                Found in src/utils/kindOf.ts - About 30 mins to fix

                  Function bindActionCreators has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  export default function bindActionCreators(
  actionCreators: ActionCreator<any> | ActionCreatorsMapObject,
  dispatch: Dispatch
) {
  if (typeof actionCreators === 'function') {
                  Severity: Minor
                  Found in src/bindActionCreators.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function paginate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  const paginate = ({ types, mapActionToKey }) => {
  if (!Array.isArray(types) || types.length !== 3) {
    throw new Error('Expected types to be an array of three elements.')
  }
  if (!types.every(t => typeof t === 'string')) {
                  Severity: Minor
                  Found in examples/real-world/src/reducers/paginate.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language