Sign upLogin

reactphp/http-client

View on GitHub
Star

Showing 11 of 11 total issues

Function iterateBuffer has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    protected function iterateBuffer()
    {
        if (strlen($this->buffer) <= 1) {
            return false;
        }
Severity: Minor
Found in src/ChunkedStreamDecoder.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method iterateBuffer has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function iterateBuffer()
    {
        if (strlen($this->buffer) <= 1) {
            return false;
        }
Severity: Major
Found in src/ChunkedStreamDecoder.php - About 2 hrs to fix

    Method writeHead has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function writeHead()
    {
        $this->state = self::STATE_WRITING_HEAD;

        $requestData = $this->requestData;
    Severity: Minor
    Found in src/Request.php - About 1 hr to fix

      Method handleData has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function handleData($data)
    {
        $this->buffer .= $data;

        // buffer until double CRLF (or double LF for compatibility with legacy servers)
      Severity: Minor
      Found in src/Request.php - About 1 hr to fix

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function __construct(ReadableStreamInterface $stream, $protocol, $version, $code, $reasonPhrase, $headers)
        Severity: Minor
        Found in src/Response.php - About 45 mins to fix

          Avoid too many return statements within this method.
          Open

                          return false;
          Severity: Major
          Found in src/ChunkedStreamDecoder.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return true;
            Severity: Major
            Found in src/ChunkedStreamDecoder.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return true;
              Severity: Major
              Found in src/ChunkedStreamDecoder.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return true;
                Severity: Major
                Found in src/ChunkedStreamDecoder.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return true;
                  Severity: Major
                  Found in src/ChunkedStreamDecoder.php - About 30 mins to fix

                    Function handleData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function handleData($data)
    {
        $this->buffer .= $data;

        // buffer until double CRLF (or double LF for compatibility with legacy servers)
                    Severity: Minor
                    Found in src/Request.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language