recurly/recurly-js

View on GitHub
packages/public-api-fixture-server/fixtures/tax/index.js

Summary

Maintainability
A
1 hr
Test Coverage

Function tax has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function tax () {
  if (this.query.country === 'US' && this.query.postal_code === USST_POSTAL_CODE && this.query.tax_code === USST_TAX_CODE) return usstWithTaxCode;
  if (this.query.country === 'US' && this.query.postal_code === USST_POSTAL_CODE) return usst;
  if (this.query.country === 'US' && this.query.postal_code === USST_POSTAL_CODE_WITH_REGION) return usstWithRegion;
  if (this.query.country === VAT_COUNTRY) return vat;
Severity: Minor
Found in packages/public-api-fixture-server/fixtures/tax/index.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

  return none;
Severity: Major
Found in packages/public-api-fixture-server/fixtures/tax/index.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      if (this.query.country === VAT_2015_COUNTRY) return vat2015;
    Severity: Major
    Found in packages/public-api-fixture-server/fixtures/tax/index.js - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status