Sign upLogin

refinery/refinerycms

View on GitHub
Star
core/app/assets/javascripts/refinery/sortable_list.js

Summary

Maintainability
C
1 day
Test Coverage

Function create_sortable_list has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

var create_sortable_list = function(options){
    ordered_list = {
        initialised: false
        , init: function(options) {
            if(!this.initialised){
Severity: Minor
Found in core/app/assets/javascripts/refinery/sortable_list.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create_sortable_list has 125 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var create_sortable_list = function(options){
    ordered_list = {
        initialised: false
        , init: function(options) {
            if(!this.initialised){
Severity: Major
Found in core/app/assets/javascripts/refinery/sortable_list.js - About 5 hrs to fix

    Function init has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            , init: function(options) {
            if(!this.initialised){
                this.update_url = options.update_url;
                this.sortable_list = $(options.sortable_list);
                this.tree = options.tree;
    Severity: Minor
    Found in core/app/assets/javascripts/refinery/sortable_list.js - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status