reinfi/zf-optimized-servicemanager

View on GitHub

Showing 6 of 8 total issues

Function buildMappings has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function buildMappings(Options $options): array
    {
        $mappings = [];

        $delegatorConfig = $this->serviceManagerConfig['delegators'] ?? [];
Severity: Minor
Found in src/Service/MappingService.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addMethods has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    protected function addMethods(
        ClassType $class,
        array $instantiationMethods,
        Options $options
    ): array {
Severity: Minor
Found in src/Service/OptimizerService.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method buildMappings has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function buildMappings(Options $options): array
    {
        $mappings = [];

        $delegatorConfig = $this->serviceManagerConfig['delegators'] ?? [];
Severity: Minor
Found in src/Service/MappingService.php - About 1 hr to fix

    Method addGetMethod has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function addGetMethod(ClassType $class, Options $options): Method
        {
            $getMethod = $class->addMethod('get')
                ->setVisibility('public')
                ->addComment('@inheritdoc');
    Severity: Minor
    Found in src/Service/ClassBuilderService.php - About 1 hr to fix

      Method addMethods has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function addMethods(
              ClassType $class,
              array $instantiationMethods,
              Options $options
          ): array {
      Severity: Minor
      Found in src/Service/OptimizerService.php - About 1 hr to fix

        Function buildBody has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function buildBody(
                InstantiationMethod $method,
                TypeInterface $type
            ) {
                $injections = $this->resolverService->resolve($type->getService());
        Severity: Minor
        Found in src/Service/Handler/AutowireHandler.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language