relaton/relaton-bib

View on GitHub

Showing 80 of 86 total issues

Method contributors_hash_to_bib has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def contributors_hash_to_bib(ret) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength,Metrics/PerceivedComplexity
      return unless ret[:contributor]

      ret[:contributor] = RelatonBib.array(ret[:contributor])
      ret[:contributor]&.each_with_index do |c, i|
Severity: Minor
Found in lib/relaton_bib/hash_converter.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method to_asciibib has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def to_asciibib(prefix = "") # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
      pref = prefix.empty? ? prefix : "#{prefix}."
      out = prefix.empty? ? "[%bibitem]\n== {blank}\n" : ""
      out += "#{pref}id:: #{id}\n" if id
      out += "#{pref}fetched:: #{fetched}\n" if fetched
Severity: Minor
Found in lib/relaton_bib/bibliographic_item.rb - About 1 hr to fix

    Method to_asciibib has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def to_asciibib(prefix = "", count = 1) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength,Metrics/PerceivedComplexity
          pref = prefix.empty? ? "series" : prefix + ".series"
          out = count > 1 ? "#{pref}::\n" : ""
          out += "#{pref}.type:: #{type}\n" if type
          out += formattedref.to_asciibib pref if formattedref
    Severity: Minor
    Found in lib/relaton_bib/series.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method to_xml has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def to_xml(builder) # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity,Metrics/MethodLength
          builder.image do
            builder.parent[:id] = id if id
            builder.parent[:src] = src
            builder.parent[:mimetype] = mimetype
    Severity: Minor
    Found in lib/relaton_bib/image.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method to_xml has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def to_xml(builder, **opts)
          builder.date(type: type) do
            if on
              builder.on(opts[:no_year] ? "--" : date_format(on, opts[:date_format]))
            elsif from
    Severity: Minor
    Found in lib/relaton_bib/bibliographic_date.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method to_asciibib has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def to_asciibib(prefix = "", count = 1, has_attrs = false) # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity,Metrics/MethodLength
          pref = prefix.empty? ? prefix : "#{prefix}."
          case content
          when String
            unless language&.any? || script&.any? || has_attrs
    Severity: Minor
    Found in lib/relaton_bib/localized_string.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method item_data has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def item_data(bibitem) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/AbcSize, Metrics/MethodLength
            ext = bibitem.at "//ext"
            {
              id: bibitem[:id].nil? || bibitem[:id].empty? ? nil : bibitem[:id],
              type: bibitem[:type].nil? || bibitem[:type].empty? ? nil : bibitem[:type],
    Severity: Minor
    Found in lib/relaton_bib/xml_parser.rb - About 1 hr to fix

      Method to_asciibib has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def to_asciibib(prefix = "", count = 1) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/AbcSize
            pref = prefix.empty? ? prefix : "#{prefix}."
            return "#{pref}docid:: #{id}\n" unless type || scope
      
            out = count > 1 ? "#{pref}docid::\n" : ""
      Severity: Minor
      Found in lib/relaton_bib/document_identifier.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method render_bibxml_ref has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

            def render_bibxml_ref(builder, include_keywords) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
              builder.reference(**ref_attrs) do |xml|
                if @bib.title.any? || @bib.contributor.any? || @bib.date.any? || @bib.abstract.any? ||
                    @bib.editorialgroup&.technical_committee&.any? ||
                    (include_keywords && @bib.keyword.any?)
      Severity: Minor
      Found in lib/relaton_bib/renderer/bibxml.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method to_xml has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def to_xml(builder) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity
            builder.medium do
              builder.content content if content
              builder.genre genre if genre
              builder.form form if form
      Severity: Minor
      Found in lib/relaton_bib/medium.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method to_xml has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def to_xml(**opts) # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity,Metrics/MethodLength
            opts[:builder].organization do |builder|
              nm = name.select { |n| n.language&.include? opts[:lang] }
              nm = name unless nm.any?
              nm.each { |n| builder.name { |b| n.to_xml b } }
      Severity: Minor
      Found in lib/relaton_bib/organization.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize(content, language = nil, script = nil) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
            if content.is_a?(Array) && content.none?
              raise ArgumentError, "LocalizedString content is empty"
            end
      
      
      Severity: Minor
      Found in lib/relaton_bib/localized_string.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method to_hash has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def to_hash # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity,Metrics/MethodLength
            hash = {}
            hash["abbreviation"] = abbreviation.to_hash if abbreviation
            if forename.any? || initials
              hash["given"] = {}
      Severity: Minor
      Found in lib/relaton_bib/full_name.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method to_asciibib has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def to_asciibib(prefix = "", count = 1) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
            pref = prefix.empty? ? "address" : "#{prefix}.address"
            if formatted_address
              "#{pref}.formatted_address:: #{formatted_address}\n"
            else
      Severity: Minor
      Found in lib/relaton_bib/contributor.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method hash_to_bib has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def hash_to_bib(args)
            return nil unless args.is_a?(Hash)
      
            ret = Marshal.load(Marshal.dump(symbolize(args))) # deep copy
            title_hash_to_bib(ret)
      Severity: Minor
      Found in lib/relaton_bib/hash_converter.rb - About 1 hr to fix

        Method docids has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def docids(reference, ver) # rubocop:disable Metrics/MethodLength,Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity,Metrics/AbcSize
              ret = []
              si = reference.at("./seriesInfo[@name='Internet-Draft']",
                                "./front/seriesInfo[@name='Internet-Draft']")
              if si
        Severity: Minor
        Found in lib/relaton_bib/bibxml_parser.rb - About 1 hr to fix

          Method to_hash has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              def to_hash
                hash = { "docnumber" => docnumber }
                hash["type"] = type if type
                hash["agency"] = single_element_array agency if agency&.any?
                hash["class"] = klass if klass
          Severity: Minor
          Found in lib/relaton_bib/structured_identifier.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method to_hash has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              def to_hash # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
                hash = {}
                hash["type"] = type if type
                hash["formattedref"] = formattedref.to_hash if formattedref
                hash["title"] = title.to_hash
          Severity: Minor
          Found in lib/relaton_bib/series.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Consider simplifying this complex logical expression.
          Open

                    if @bib.title.any? || @bib.contributor.any? || @bib.date.any? || @bib.abstract.any? ||
                        @bib.editorialgroup&.technical_committee&.any? ||
                        (include_keywords && @bib.keyword.any?)
                      xml.front do
                        xml.title @bib.title[0].title.content if @bib.title.any?
          Severity: Major
          Found in lib/relaton_bib/renderer/bibxml.rb - About 1 hr to fix

            Method to_asciibib has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                def to_asciibib(prefix = "") # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity,Metrics/MethodLength
                  pref = prefix.empty? ? "image." : "#{prefix}.image."
                  out = ""
                  out += "#{pref}id:: #{id}\n" if id
                  out += "#{pref}src:: #{src}\n"
            Severity: Minor
            Found in lib/relaton_bib/image.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language