Sign upLogin

remotestorage/remotestorage-server

View on GitHub
Star
lib/main.js

Summary

Maintainability
D
2 days
Test Coverage

Function condMet has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

module.exports.prototype.condMet = function(cond, username, path, cb) {
  this.getRevision(username, path, function(err, revision) {
    var i, found;
    if (err) {
      cb(err);
Severity: Minor
Found in lib/main.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getFolderDescription has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

module.exports.prototype.getFolderDescription = function(username, path, folderFormat, cb) {
  this.getContent(username, path, function(err, content) {
    var i, itemNames, revisions = {}, todo = 1, error, errorSent;
    if (content) {
      try {
Severity: Minor
Found in lib/main.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File main.js has 252 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var sha1 = require('sha1');

module.exports = function(dataStore) {
  this.dataStore = dataStore;
};
Severity: Minor
Found in lib/main.js - About 2 hrs to fix

    Function getFolderDescription has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports.prototype.getFolderDescription = function(username, path, folderFormat, cb) {
  this.getContent(username, path, function(err, content) {
    var i, itemNames, revisions = {}, todo = 1, error, errorSent;
    if (content) {
      try {
    Severity: Minor
    Found in lib/main.js - About 1 hr to fix

      Function revisionsToMap has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports.prototype.revisionsToMap = function(revisions, username, path, cb) {
  var i, items = {}, todo = 1, error, errorSent;
  function doneOne() {
    if (error) {
      if (!errorSent) {
      Severity: Minor
      Found in lib/main.js - About 1 hr to fix

        Function setParents has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports.prototype.setParents = function(username, pathParts, fileItself, revision, cb) {
  if (pathParts.length <= 1) {
    cb();
  } else {
    var thisPart = pathParts.pop();
        Severity: Minor
        Found in lib/main.js - About 1 hr to fix

          Function condMet has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports.prototype.condMet = function(cond, username, path, cb) {
  this.getRevision(username, path, function(err, revision) {
    var i, found;
    if (err) {
      cb(err);
          Severity: Minor
          Found in lib/main.js - About 1 hr to fix

            Function revisionsToMap has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports.prototype.revisionsToMap = function(revisions, username, path, cb) {
  var i, items = {}, todo = 1, error, errorSent;
  function doneOne() {
    if (error) {
      if (!errorSent) {
            Severity: Minor
            Found in lib/main.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function set has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports.prototype.set = function(username, path, dataBuf, contentType, revision, cb) {
  this.dataStore.set(username, 'content:' + path, dataBuf, function(err1) {
    if (err1) {
      cb(err1);
      return;
            Severity: Minor
            Found in lib/main.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function set has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            module.exports.prototype.set = function(username, path, dataBuf, contentType, revision, cb) {
            Severity: Minor
            Found in lib/main.js - About 45 mins to fix

              Function setParents has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              module.exports.prototype.setParents = function(username, pathParts, fileItself, revision, cb) {
              Severity: Minor
              Found in lib/main.js - About 35 mins to fix

                Function getRevision has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                module.exports.prototype.getRevision = function(username, path, cb) {
  this.dataStore.get(username, 'revision:' + path, function(err, revision) {
    if (err) {
      cb(err);
      return;
                Severity: Minor
                Found in lib/main.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                module.exports.prototype.getContent = function(username, path, cb) {
  this.dataStore.get(username, 'content:' + path, cb);
};
                Severity: Minor
                Found in lib/main.js and 1 other location - About 40 mins to fix
                lib/main.js on lines 154..156

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                module.exports.prototype.getContentType = function(username, path, cb) {
  this.dataStore.get(username, 'contentType:' + path, cb);
};
                Severity: Minor
                Found in lib/main.js and 1 other location - About 40 mins to fix
                lib/main.js on lines 151..153

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status