Sign upLogin

reneklacan/kabutops

View on GitHub
Star

Showing 4 of 7 total issues

Method perform has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def perform resource
      resource = Hashie::Mash.new(resource)

      adapters = self.class.adapters.select do |adapter|
        params.skip_existing ? adapter.find(resource).nil? : true
Severity: Minor
Found in lib/kabutops/crawler.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_one has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def process_one resource, page, result
        result.update(updated_at: Time.now.to_i)
        save = (notify(:save_if, resource, page, result) || []).all?

        logger.info("#{self.class.to_s} outputs:") if debug
Severity: Minor
Found in lib/kabutops/adapters/database_adapter.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find_outdated has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def find_outdated freshness
        result = client.search(
          index: params[:index] || 'default',
          body: {
            query: {
Severity: Minor
Found in lib/kabutops/adapters/elastic_search.rb - About 1 hr to fix

    Method params has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def params *list
          list.each do |name|
            define_method name do |*args|
              @params ||= Hashie::Mash.new
              if args.size == 1
    Severity: Minor
    Found in lib/kabutops/extensions/parameterable.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language