File metadata.rb has 402 lines of code (exceeds 250 allowed). Consider refactoring.

Open

module Ridley::Chef
  class Cookbook
    # Borrowed and modified from: {https://raw.github.com/opscode/chef/11.4.0/lib/chef/cookbook/metadata.rb}
    #
    # Copyright:: Copyright 2008-2010 Opscode, Inc.

Class Metadata has 40 methods (exceeds 20 allowed). Consider refactoring.

Open

    class Metadata
      class << self
        def from_hash(hash)
          new.from_hash(hash)
        end

Method from_hash has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.

Open

      def from_hash(o)
        @name             = o[NAME] if o.has_key?(NAME)
        @description      = o[DESCRIPTION] if o.has_key?(DESCRIPTION)
        @long_description = o[LONG_DESCRIPTION] if o.has_key?(LONG_DESCRIPTION)
        @maintainer       = o[MAINTAINER] if o.has_key?(MAINTAINER)

• Read up
  Read up

Class Cookbook has 22 methods (exceeds 20 allowed). Consider refactoring.

Open

  class Cookbook
    require_relative 'cookbook/metadata'
    require_relative 'cookbook/syntax_check'

    class << self

Method validate has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.

Open

    def validate(opts, map)
      #--
      # validate works by taking the keys in the validation map, assuming it's a hash, and
      # looking for _pv_:symbol as methods.  Assuming it find them, it calls the right
      # one.

• Read up
  Read up

Method build_query has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.

Open

      def build_query(query_string, options = {})
        {}.tap do |query_opts|
          query_opts[:q]     = query_string unless query_string.nil?
          query_opts[:sort]  = options[:sort] unless options[:sort].nil?
          query_opts[:rows]  = options[:rows] unless options[:rows].nil?

• Read up
  Read up

Method stream has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def stream(target, destination)
      FileUtils.mkdir_p(File.dirname(destination))

      target  = Addressable::URI.parse(target)
      headers = Middleware::ChefAuth.authentication_headers(

Method initialize has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def initialize(cookbook = nil, maintainer = 'YOUR_COMPANY_NAME', maintainer_email = 'YOUR_EMAIL', license = 'none')
        @cookbook = cookbook
        @name = cookbook ? cookbook.name : ""
        @long_description = ""
        self.maintainer(maintainer)

Method upload has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def upload(sandbox, chk_id, file)
      checksum = sandbox.checksum(chk_id)

      unless checksum[:needs_upload]
        return nil

Method _pv_regex has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.

Open

      def _pv_regex(opts, key, regex)
        value = _pv_opts_lookup(opts, key)
        if value != nil
          passes = false
          [ regex ].flatten.each do |r|

• Read up
  Read up

Method initialize has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def initialize(server_url, client_name, client_key, options = {})
      options         = options.reverse_merge(retries: 5, retry_interval: 0.5)
      @client_name    = client_name
      @client_key     = client_key
      @retries        = options.delete(:retries)

Method upload has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def upload(path, options = {})
      options  = options.reverse_merge(validate: true, force: false, freeze: false)
      cookbook = Ridley::Chef::Cookbook.from_path(path)

      unless (existing = find(cookbook.cookbook_name, cookbook.version)).nil?

Method initialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

Open

    def initialize(options = {})
      @options = options.reverse_merge(
        pool_size: 4
      ).deep_symbolize_keys
      self.class.validate_options(@options)

• Read up
  Read up

Method stream has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

Open

    def stream(target, destination)
      FileUtils.mkdir_p(File.dirname(destination))

      target  = Addressable::URI.parse(target)
      headers = Middleware::ChefAuth.authentication_headers(

• Read up
  Read up

Method validate_choice_default_rule has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

Open

        def validate_choice_default_rule(options)
          return if !options[:choice].is_a?(Array) || options[:choice].empty?

          if options[:default].is_a?(String) && options[:default] != ""
            raise ArgumentError, "Default must be one of your choice values!" if options[:choice].index(options[:default]) == nil

• Read up
  Read up

Method _pv_equal_to has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

      def _pv_equal_to(opts, key, to_be)
        value = _pv_opts_lookup(opts, key)
        unless value.nil?
          passes = false
          Array(to_be).each do |tb|

• Read up
  Read up

Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    def initialize(server_url, client_name, client_key, options = {})
      options         = options.reverse_merge(retries: 5, retry_interval: 0.5)
      @client_name    = client_name
      @client_key     = client_key
      @retries        = options.delete(:retries)

• Read up
  Read up

Method load_recursively has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

      def load_recursively(category, category_dir, glob)
        [].tap do |files|
          file_spec = path.join(category_dir, '**', glob)
          Dir.glob(file_spec, File::FNM_DOTMATCH).each do |file|
            next if File.directory?(file)

• Read up
  Read up

Method upload has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    def upload(sandbox, chk_id, file)
      checksum = sandbox.checksum(chk_id)

      unless checksum[:needs_upload]
        return nil

• Read up
  Read up

Method load_root has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

      def load_root
        [].tap do |files|
          Dir.glob(path.join('*'), File::FNM_DOTMATCH).each do |file|
            next if File.directory?(file)
            next if ignored?(file)

• Read up
  Read up