resource-watch/adapter-arcgis

View on GitHub

Showing 15 of 23 total issues

Function queryMiddleware has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
Open

const queryMiddleware = async (ctx, next) => {
    const options = {
        method: 'GET',
        json: true,
        resolveWithFullResponse: true,
Severity: Minor
Found in app/src/routes/api/v1/arcgis.router.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function queryMiddleware has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const queryMiddleware = async (ctx, next) => {
    const options = {
        method: 'GET',
        json: true,
        resolveWithFullResponse: true,
Severity: Major
Found in app/src/routes/api/v1/arcgis.router.js - About 3 hrs to fix

    Function exports has 79 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = (grunt) => {
    
        grunt.file.setBase('..');
        // eslint-disable-next-line import/no-extraneous-dependencies
        require('load-grunt-tasks')(grunt);
    Severity: Major
    Found in app/Gruntfile.js - About 3 hrs to fix

      Function convertObject has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          convertObject(data) {
              if (this.jsonSql && this.jsonSql.select) {
                  let column;
                  for (let i = 0, { length } = this.jsonSql.select; i < length; i += 1) {
                      column = this.jsonSql.select[i];
      Severity: Minor
      Found in app/src/services/query.service.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function execute has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          async execute() {
              logger.info('Executing query');
              this.first = true;
              if (!this.download) {
                  this.passthrough.write(`{"data":[`);
      Severity: Minor
      Found in app/src/services/query.service.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function init has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      async function init() {
          return new Promise((resolve) => {
      
              const app = new Koa();
      
      
      Severity: Minor
      Found in app/src/app.js - About 1 hr to fix

        Function exports has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = (() => {
        
            const loadAPI = (app, path, pathApi) => {
                const routesFiles = fs.readdirSync(path);
                let existIndexRouter = false;
        Severity: Minor
        Found in app/src/loader.js - About 1 hr to fix

          Function execute has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              async execute() {
                  logger.info('Executing query');
                  this.first = true;
                  if (!this.download) {
                      this.passthrough.write(`{"data":[`);
          Severity: Minor
          Found in app/src/services/query.service.js - About 1 hr to fix

            Function registerDataset has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                static async registerDataset(ctx) {
                    logger.info('Registering dataset with data', ctx.request.body);
                    try {
                        await ArcgisService.getFields(ctx.request.body.connector.connector_url);
                        await RWAPIMicroservice.requestToMicroservice({
            Severity: Minor
            Found in app/src/routes/api/v1/arcgis.router.js - About 1 hr to fix

              Function loadAPI has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  const loadAPI = (app, path, pathApi) => {
                      const routesFiles = fs.readdirSync(path);
                      let existIndexRouter = false;
                      routesFiles.forEach((file) => {
                          const newPath = path ? (`${path}/${file}`) : file;
              Severity: Minor
              Found in app/src/loader.js - About 1 hr to fix

                Function writeRequest has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    async writeRequest(request) {
                        let count = 0;
                        return new Promise((resolve, reject) => {
                            let parser = null;
                            if (this.sql.indexOf('returnCountOnly') >= 0) {
                Severity: Minor
                Found in app/src/services/query.service.js - About 1 hr to fix

                  Function query has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      static async query(ctx) {
                          ctx.set('Content-type', 'application/json');
                          const cloneUrl = ArcgisRouter.getCloneUrl(ctx.request.url, ctx.params.dataset);
                          try {
                              ctx.body = passThrough();
                  Severity: Minor
                  Found in app/src/routes/api/v1/arcgis.router.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function exports has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                  module.exports = (() => {
                  
                      const loadAPI = (app, path, pathApi) => {
                          const routesFiles = fs.readdirSync(path);
                          let existIndexRouter = false;
                  Severity: Minor
                  Found in app/src/loader.js - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid deeply nested control flow statements.
                  Open

                                          for (let i = 0; i < json2sql.select.length; i += 1) {
                                              if (json2sql.select[i].type === 'literal') {
                                                  if (groups[j] === json2sql.select[i].alias) {
                                                      groups[j] = json2sql.select[i].value;
                                                  }
                  Severity: Major
                  Found in app/src/routes/api/v1/arcgis.router.js - About 45 mins to fix

                    Function download has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        static async download(ctx) {
                            try {
                                ctx.body = passThrough();
                                const format = ctx.query.format ? ctx.query.format : 'csv';
                                let mimetype;
                    Severity: Minor
                    Found in app/src/routes/api/v1/arcgis.router.js - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language