Sign upLogin

resource-watch/adapter-gfw

View on GitHub
Star

Showing 8 of 10 total issues

Function init has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const init: () => Promise<IInit> = async (): Promise<IInit> => {
    return new Promise((resolve: (value: IInit | PromiseLike<IInit>) => void,
    ) => {
        const app: Koa = new Koa();
Severity: Major
Found in src/app.ts - About 2 hrs to fix

    Function toSQLMiddleware has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const toSQLMiddleware: (ctx: Context, next: Next) => Promise<void> = async (
    ctx: Context,
    next: Next,
) => {
    const options: RequestToMicroserviceOptions & request.OptionsWithUri = {
    Severity: Major
    Found in src/routes/gfw.router.ts - About 2 hrs to fix

      Function executeQuery has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          static async executeQuery(
        urlDataset: string,
        sqlQuery: string,
        download: boolean,
        format: string,
      Severity: Minor
      Found in src/services/gfw.service.ts - About 1 hr to fix

        Function registerDataset has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            static async registerDataset(ctx: Context): Promise<void> {
        logger.info('Registering dataset with data', ctx.request.body);
        try {
            await GfwService.getFields(ctx.request.body.connector.connectorUrl);
            await RWAPIMicroservice.requestToMicroservice({
        Severity: Minor
        Found in src/routes/gfw.router.ts - About 1 hr to fix

          Function download has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              static async download(ctx: Context): Promise<void> {
        try {
            const format: string = ctx.query.format
                ? (ctx.query.format as string)
                : 'csv';
          Severity: Minor
          Found in src/routes/gfw.router.ts - About 1 hr to fix

            Function toSQLMiddleware has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

            const toSQLMiddleware: (ctx: Context, next: Next) => Promise<void> = async (
    ctx: Context,
    next: Next,
) => {
    const options: RequestToMicroserviceOptions & request.OptionsWithUri = {
            Severity: Minor
            Found in src/routes/gfw.router.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function executeQuery has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                static async executeQuery(
        urlDataset: string,
        sqlQuery: string,
        download: boolean,
        format: string,
            Severity: Minor
            Found in src/services/gfw.service.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function download has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                static async download(ctx: Context): Promise<void> {
        try {
            const format: string = ctx.query.format
                ? (ctx.query.format as string)
                : 'csv';
            Severity: Minor
            Found in src/routes/gfw.router.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language