Sign upLogin

resource-watch/dataset

View on GitHub
Star
src/services/relationships.service.js

Summary

Maintainability
F
3 days
Test Coverage

File relationships.service.js has 350 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const { default: logger } = require('logger');
const { RWAPIMicroservice } = require('rw-api-microservice-node');
const { INCLUDES } = require('app.constants');
const { compact, uniq, startsWith, pickBy } = require('lodash');
const InvalidRequest = require('errors/invalidRequest.error');
Severity: Minor
Found in src/services/relationships.service.js - About 4 hrs to fix

    Function getResources has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        static async getResources(ids, includes, apiKey, query = '', users = [], isAdmin = false) {
        logger.info(`Getting resources of ids: ${ids}`);
        delete query.ids;
        delete query.usersRole;
        let resources = includes.map(async (include) => {
    Severity: Minor
    Found in src/services/relationships.service.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getResources has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static async getResources(ids, includes, apiKey, query = '', users = [], isAdmin = false) {
        logger.info(`Getting resources of ids: ${ids}`);
        delete query.ids;
        delete query.usersRole;
        let resources = includes.map(async (include) => {
    Severity: Major
    Found in src/services/relationships.service.js - About 3 hrs to fix

      Function resources has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              let resources = includes.map(async (include) => {
            const obj = {};
            if (INCLUDES.indexOf(include) >= 0) {
                let uri = '/v1';
                let payload = {
      Severity: Minor
      Found in src/services/relationships.service.js - About 2 hrs to fix

        Function getRelationships has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            static async getRelationships(datasets, includes, apiKey, query = '', isAdmin = false) {
        logger.info(`Getting relationships of datasets`, isAdmin);
        datasets.unshift({});
        const map = datasets.reduce((acc, val) => {
            acc[val._id] = val;
        Severity: Minor
        Found in src/services/relationships.service.js - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                                  } else if (Object.keys(result).indexOf(el.attributes.dataset) < 0) {
                            result[el.attributes.dataset] = [el];
                        } else {
                            result[el.attributes.dataset].push(el);
                        }
          Severity: Major
          Found in src/services/relationships.service.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                        if (isAdmin) {
                                result[el._id] = el;
                            }
            Severity: Major
            Found in src/services/relationships.service.js - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  static async cloneVocabularies(oldId, newId, apiKey) {
        try {
            return await RWAPIMicroservice.requestToMicroservice({
                uri: `/v1/dataset/${oldId}/vocabulary/clone/dataset`,
                method: 'POST',
              Severity: Major
              Found in src/services/relationships.service.js and 1 other location - About 2 hrs to fix
              src/services/relationships.service.js on lines 231..247

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 92.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  static async cloneMetadatas(oldId, newId, apiKey) {
        try {
            return await RWAPIMicroservice.requestToMicroservice({
                uri: `/v1/dataset/${oldId}/metadata/clone`,
                method: 'POST',
              Severity: Major
              Found in src/services/relationships.service.js and 1 other location - About 2 hrs to fix
              src/services/relationships.service.js on lines 213..229

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 92.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              const serializeObjToQuery = (obj) => Object.keys(obj).reduce((a, k) => {
    a.push(`${k}=${encodeURIComponent(obj[k])}`);
    return a;
}, []).join('&');
              Severity: Major
              Found in src/services/relationships.service.js and 1 other location - About 2 hrs to fix
              src/routes/api/v1/dataset.router.js on lines 29..32

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 79.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          const result = await RWAPIMicroservice.requestToMicroservice({
                uri: `/v1/favourite/find-by-user`,
                method: 'POST',
                json: true,
                body: {
              Severity: Major
              Found in src/services/relationships.service.js and 1 other location - About 1 hr to fix
              src/services/relationships.service.js on lines 251..262

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 65.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          const result = await RWAPIMicroservice.requestToMicroservice({
                uri: `/v1/collection/find-by-ids`,
                method: 'POST',
                json: true,
                body: {
              Severity: Major
              Found in src/services/relationships.service.js and 1 other location - About 1 hr to fix
              src/services/relationships.service.js on lines 271..282

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 65.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                      const result = await RWAPIMicroservice.requestToMicroservice({
            uri: `/v1/dataset/vocabulary/find${vocabularyQuery}`,
            method: 'GET',
            json: true,
            headers: {
              Severity: Major
              Found in src/services/relationships.service.js and 3 other locations - About 55 mins to fix
              src/services/dataset.service.js on lines 543..550
              src/services/dataset.service.js on lines 560..567
              src/services/sync.service.js on lines 62..69

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 53.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status