Sign upLogin

resource-watch/doc-orchestrator

View on GitHub
Star
app/src/services/status-queue.service.js

Summary

Maintainability
D
2 days
Test Coverage
B
88%

File status-queue.service.js has 274 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const logger = require('logger');
const QueueService = require('services/queue.service');
const TaskService = require('services/task.service');
const DatasetService = require('services/dataset.service');
const { execution, status, task } = require('rw-doc-importer-messages');
Severity: Minor
Found in app/src/services/status-queue.service.js - About 2 hrs to fix

    Function processMessage has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async processMessage() {

        switch (this.statusMsg.type) {

            case status.MESSAGE_TYPES.STATUS_INDEX_DEACTIVATED:
    Severity: Minor
    Found in app/src/services/status-queue.service.js - About 1 hr to fix

      Function indexCreated has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          async indexCreated() {
        const dataset = await DatasetService.get(this.currentTask.datasetId);
        const { connectorUrl, sources } = dataset.data.attributes;

        const datasetProps = {
      Severity: Minor
      Found in app/src/services/status-queue.service.js - About 1 hr to fix

        Function importConfirmed has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            async importConfirmed() {
        switch (this.currentTask.type) {

            case task.MESSAGE_TYPES.TASK_OVERWRITE:
                await this.sendExecutionTask(execution.MESSAGE_TYPES.EXECUTION_DELETE_INDEX, [{ index: 'message.index' }]);
        Severity: Minor
        Found in app/src/services/status-queue.service.js - About 1 hr to fix

          Function indexCreated has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              async indexCreated() {
        const dataset = await DatasetService.get(this.currentTask.datasetId);
        const { connectorUrl, sources } = dataset.data.attributes;

        const datasetProps = {
          Severity: Minor
          Found in app/src/services/status-queue.service.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                          if (this.currentTask.index && (this.currentTask.index !== this.statusMsg.index)) {
                    await this.sendExecutionTask(execution.MESSAGE_TYPES.EXECUTION_DELETE_INDEX, [{ index: 'index' }]);
                    await TaskService.resetCounters(this.currentTask._id);
                }
          Severity: Major
          Found in app/src/services/status-queue.service.js and 2 other locations - About 2 hrs to fix
          app/src/services/status-queue.service.js on lines 56..59
          app/src/services/status-queue.service.js on lines 93..96

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if ((this.currentTask.index) && (this.currentTask.index !== this.statusMsg.index)) {
            await this.sendExecutionTask(execution.MESSAGE_TYPES.EXECUTION_DELETE_INDEX, [{ index: 'index' }]);
            await TaskService.resetCounters(this.currentTask._id);
        }
          Severity: Major
          Found in app/src/services/status-queue.service.js and 2 other locations - About 2 hrs to fix
          app/src/services/status-queue.service.js on lines 56..59
          app/src/services/status-queue.service.js on lines 66..69

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                          if (this.currentTask.index && (this.currentTask.index !== this.statusMsg.index)) {
                    await this.sendExecutionTask(execution.MESSAGE_TYPES.EXECUTION_DELETE_INDEX, [{ index: 'index' }]);
                    await TaskService.resetCounters(this.currentTask._id);
                }
          Severity: Major
          Found in app/src/services/status-queue.service.js and 2 other locations - About 2 hrs to fix
          app/src/services/status-queue.service.js on lines 66..69
          app/src/services/status-queue.service.js on lines 93..96

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              constructor() {
        super(config.get('queues.status'), true);
        this.statusMsg = {};
        this.currentTask = {};
    }
          Severity: Minor
          Found in app/src/services/status-queue.service.js and 1 other location - About 40 mins to fix
          app/src/services/tasks-queue.service.js on lines 12..16

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

                  await TaskService.update(this.currentTask._id, {
            status: TASK_STATUS.INDEX_CREATED,
            index: this.statusMsg.index
        });
          Severity: Major
          Found in app/src/services/status-queue.service.js and 5 other locations - About 30 mins to fix
          app/src/services/status-queue.service.js on lines 84..87
          app/src/services/status-queue.service.js on lines 166..169
          app/src/services/status-queue.service.js on lines 221..224
          app/src/services/status-queue.service.js on lines 252..255
          app/src/services/status-queue.service.js on lines 256..259

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

                  await TaskService.update(this.currentTask._id, {
            status: TASK_STATUS.PERFORMED_REINDEX,
            elasticTaskId: this.statusMsg.elasticTaskId
        });
          Severity: Major
          Found in app/src/services/status-queue.service.js and 5 other locations - About 30 mins to fix
          app/src/services/status-queue.service.js on lines 84..87
          app/src/services/status-queue.service.js on lines 97..100
          app/src/services/status-queue.service.js on lines 166..169
          app/src/services/status-queue.service.js on lines 252..255
          app/src/services/status-queue.service.js on lines 256..259

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

                  await TaskService.update(this.currentTask._id, {
            status: TASK_STATUS.ERROR,
            error: this.statusMsg.error
        });
          Severity: Major
          Found in app/src/services/status-queue.service.js and 5 other locations - About 30 mins to fix
          app/src/services/status-queue.service.js on lines 84..87
          app/src/services/status-queue.service.js on lines 97..100
          app/src/services/status-queue.service.js on lines 166..169
          app/src/services/status-queue.service.js on lines 221..224
          app/src/services/status-queue.service.js on lines 256..259

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

                  await DatasetService.update(this.currentTask.datasetId, {
            status: DATASET_STATUS.ERROR,
            errorMessage: this.statusMsg.error
        });
          Severity: Major
          Found in app/src/services/status-queue.service.js and 5 other locations - About 30 mins to fix
          app/src/services/status-queue.service.js on lines 84..87
          app/src/services/status-queue.service.js on lines 97..100
          app/src/services/status-queue.service.js on lines 166..169
          app/src/services/status-queue.service.js on lines 221..224
          app/src/services/status-queue.service.js on lines 252..255

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

                  await TaskService.update(this.currentTask._id, {
            status: TASK_STATUS.INDEX_CREATED,
            index: this.statusMsg.index
        });
          Severity: Major
          Found in app/src/services/status-queue.service.js and 5 other locations - About 30 mins to fix
          app/src/services/status-queue.service.js on lines 97..100
          app/src/services/status-queue.service.js on lines 166..169
          app/src/services/status-queue.service.js on lines 221..224
          app/src/services/status-queue.service.js on lines 252..255
          app/src/services/status-queue.service.js on lines 256..259

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

                  await TaskService.update(this.currentTask._id, {
            status: TASK_STATUS.PERFORMED_DELETE_QUERY,
            elasticTaskId: this.statusMsg.elasticTaskId
        });
          Severity: Major
          Found in app/src/services/status-queue.service.js and 5 other locations - About 30 mins to fix
          app/src/services/status-queue.service.js on lines 84..87
          app/src/services/status-queue.service.js on lines 97..100
          app/src/services/status-queue.service.js on lines 221..224
          app/src/services/status-queue.service.js on lines 252..255
          app/src/services/status-queue.service.js on lines 256..259

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status