Sign upLogin

resource-watch/document-adapter

View on GitHub
Star
app/src/routes/api/v1/query.router.js

Summary

Maintainability
D
2 days
Test Coverage
C
74%

Function toSQLMiddleware has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

const toSQLMiddleware = async (ctx, next) => {

    const options = {
        method: 'GET',
        headers: {
Severity: Minor
Found in app/src/routes/api/v1/query.router.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function toSQLMiddleware has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const toSQLMiddleware = async (ctx, next) => {

    const options = {
        method: 'GET',
        headers: {
Severity: Major
Found in app/src/routes/api/v1/query.router.js - About 2 hrs to fix

    Function checkUserHasPermission has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    const checkUserHasPermission = (user, dataset) => {

    if (user && dataset) {
        if (user.id === 'microservice') {
            return true;
    Severity: Minor
    Found in app/src/routes/api/v1/query.router.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function query has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static async query(ctx) {
        logger.info('Do Query with dataset', ctx.request.body);
        logger.debug('Checking if is delete or select');

        try {
    Severity: Minor
    Found in app/src/routes/api/v1/query.router.js - About 1 hr to fix

      Function checkPermissionDelete has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      const checkPermissionDelete = async (ctx, next) => {
    if (ctx.state.parsed.delete) {
        if (!ctx.request.body || !ctx.request.body.loggedUser) {
            ctx.throw(403, 'Not authorized to execute DELETE query');
            return;
      Severity: Minor
      Found in app/src/routes/api/v1/query.router.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function containApps has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      const containApps = (apps1, apps2) => {
    if (!apps1 || !apps2) {
        return false;
    }
    for (let i = 0, { length } = apps1; i < length; i += 1) {
      Severity: Minor
      Found in app/src/routes/api/v1/query.router.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function query has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          static async query(ctx) {
        logger.info('Do Query with dataset', ctx.request.body);
        logger.debug('Checking if is delete or select');

        try {
      Severity: Minor
      Found in app/src/routes/api/v1/query.router.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      const checkUserHasPermission = (user, dataset) => {

    if (user && dataset) {
        if (user.id === 'microservice') {
            return true;
      Severity: Major
      Found in app/src/routes/api/v1/query.router.js and 1 other location - About 4 hrs to fix
      app/src/routes/api/v1/dataset.router.js on lines 143..158

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 133.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      const containApps = (apps1, apps2) => {
    if (!apps1 || !apps2) {
        return false;
    }
    for (let i = 0, { length } = apps1; i < length; i += 1) {
      Severity: Major
      Found in app/src/routes/api/v1/query.router.js and 1 other location - About 4 hrs to fix
      app/src/routes/api/v1/dataset.router.js on lines 129..141

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 127.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status