Sign upLogin

resource-watch/document-adapter

View on GitHub
Star
app/src/serializers/jsonSerializer.js

Summary

Maintainability
F
1 wk
Test Coverage
C
78%

Function formatAlias has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    static formatAlias(el, parsedQuery) {
        if (!parsedQuery || !el) {
            return el;
        }
Severity: Minor
Found in app/src/serializers/jsonSerializer.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function serialize has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    static serialize(data, parsed, format = 'json') {
        if (!data) {
            return {
                data: []
            };
Severity: Minor
Found in app/src/serializers/jsonSerializer.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function serialize has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static serialize(data, parsed, format = 'json') {
        if (!data) {
            return {
                data: []
            };
Severity: Major
Found in app/src/serializers/jsonSerializer.js - About 2 hrs to fix

    Function serializeBucket has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        static serializeBucket(key, buckets) {
        let list = [];
        let alias = key;
        if (key.indexOf('geohash') >= 0) {
            alias = 'geohash';
    Severity: Minor
    Found in app/src/serializers/jsonSerializer.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function serializeBucket has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static serializeBucket(key, buckets) {
        let list = [];
        let alias = key;
        if (key.indexOf('geohash') >= 0) {
            alias = 'geohash';
    Severity: Minor
    Found in app/src/serializers/jsonSerializer.js - About 1 hr to fix

      Function formatAlias has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          static formatAlias(el, parsedQuery) {
        if (!parsedQuery || !el) {
            return el;
        }
      Severity: Minor
      Found in app/src/serializers/jsonSerializer.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                            if (el[name]) {
                        target[currentSelectElement.alias] = el[name];
                    }
        Severity: Major
        Found in app/src/serializers/jsonSerializer.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if (key.match(stripESSuffix)) {
                            sanitizedKey = key.toLowerCase().replace(stripESSuffix, '');
                        }
          Severity: Major
          Found in app/src/serializers/jsonSerializer.js - About 45 mins to fix

            Avoid too many return statements within this function.
            Open

                    return null;
            Severity: Major
            Found in app/src/serializers/jsonSerializer.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return {
                data: data.hits.hits.map((el) => {
                    // eslint-disable-next-line no-underscore-dangle
                    const formatted = JSONSerializer.formatAlias(Object.assign(el._source, {
                        _id: el._id
              Severity: Major
              Found in app/src/serializers/jsonSerializer.js - About 30 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    static formatAlias(el, parsedQuery) {
        if (!parsedQuery || !el) {
            return el;
        }
                Severity: Major
                Found in app/src/serializers/jsonSerializer.js and 1 other location - About 2 days to fix
                app/src/serializers/csvSerializer.js on lines 41..77

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 476.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            if (!data.aggregations[keys[0]].buckets && keys[0].indexOf('NESTED') > -1) {
                const nestedKeys = Object.keys(data.aggregations[keys[0]]);
                const nested = data.aggregations[keys[0]];
                for (let i = 0, { length } = nestedKeys; i < length; i += 1) {
                    if (nested[nestedKeys[i]].buckets) {
                Severity: Major
                Found in app/src/serializers/jsonSerializer.js and 1 other location - About 1 day to fix
                app/src/serializers/csvSerializer.js on lines 98..110

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 217.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            } else if (keys.length === 1 && keys[0].indexOf('NESTED') > -1) {
                const partialList = JSONSerializer.serializeBucket(keys[0].replace('@NESTED', ''), buckets[i][keys[0]][keys[0].replace('@NESTED', '')].buckets);
                for (let j = 0, { length } = partialList; j < length; j += 1) {
                    partialList[j][alias] = buckets[i].key;
                }
                Severity: Major
                Found in app/src/serializers/jsonSerializer.js and 1 other location - About 5 hrs to fix
                app/src/serializers/csvSerializer.js on lines 20..36

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 140.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            if (keys.length === 1 && buckets[i][keys[0]].buckets && keys[0].indexOf('NESTED') === -1) {
                const partialList = JSONSerializer.serializeBucket(keys[0], buckets[i][keys[0]].buckets);
                for (let j = 0, { length: partialListLength } = partialList; j < partialListLength; j += 1) {
                    partialList[j][alias] = buckets[i].key;
                }
                Severity: Major
                Found in app/src/serializers/jsonSerializer.js and 1 other location - About 3 hrs to fix
                app/src/serializers/csvSerializer.js on lines 14..36

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 114.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                    if (buckets[i][key].value) {
                        let sanitizedKey = key;
                        if (key.match(stripESSuffix)) {
                            sanitizedKey = key.toLowerCase().replace(stripESSuffix, '');
                        }
                Severity: Major
                Found in app/src/serializers/jsonSerializer.js and 1 other location - About 1 hr to fix
                app/src/serializers/jsonSerializer.js on lines 100..106

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 71.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                keys.forEach((key) => {
                    let sanitizedKey = key;
                    if (key.match(stripESSuffix)) {
                        sanitizedKey = key.toLowerCase().replace(stripESSuffix, '');
                    }
                Severity: Major
                Found in app/src/serializers/jsonSerializer.js and 1 other location - About 1 hr to fix
                app/src/serializers/jsonSerializer.js on lines 35..41

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 71.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status