Sign upLogin

resource-watch/query

View on GitHub
Star
app/src/routes/api/v1/query.router.js

Summary

Maintainability
C
7 hrs
Test Coverage
F
48%

Function query has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    static async query(ctx) {
        logger.info('Doing query');

        const options = await QueryService.getTargetQuery(ctx, ctx.path.split('/')[1]);
        logger.debug('Doing request to adapter', options);
Severity: Minor
Found in app/src/routes/api/v1/query.router.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function jiminy has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static async jiminy(ctx) {
        logger.info('Doing jiminy');
        try {

            const options = await QueryService.getTargetQuery(ctx, 'query');
Severity: Minor
Found in app/src/routes/api/v1/query.router.js - About 1 hr to fix

    Function query has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static async query(ctx) {
        logger.info('Doing query');

        const options = await QueryService.getTargetQuery(ctx, ctx.path.split('/')[1]);
        logger.debug('Doing request to adapter', options);
    Severity: Minor
    Found in app/src/routes/api/v1/query.router.js - About 1 hr to fix

      Function freeze has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          static async freeze(options) {
        const nameFile = `${Date.now()}.json`;
        try {
            logger.debug('Obtaining data');
            const data = await requestPromise(options);
      Severity: Minor
      Found in app/src/routes/api/v1/query.router.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                req.on('response', (response) => {
            ctx.response.status = response.statusCode;
            ctx.set(getHeadersFromResponse(response));
        });
        Severity: Minor
        Found in app/src/routes/api/v1/query.router.js and 1 other location - About 50 mins to fix
        app/src/routes/api/v1/query.router.js on lines 70..73

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    req.on('response', (response) => {
                ctx.response.status = response.statusCode;
                ctx.set(getHeadersFromResponse(response));
            });
        Severity: Minor
        Found in app/src/routes/api/v1/query.router.js and 1 other location - About 50 mins to fix
        app/src/routes/api/v1/query.router.js on lines 120..123

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status