Sign upLogin

resource-watch/query

View on GitHub
Star
app/src/services/query.service.js

Summary

Maintainability
D
2 days
Test Coverage
F
46%

Function isFunction has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    static isFunction(parsed) {
        logger.debug('Checking if it is a function', parsed);

        if (!parsed.select || parsed.select.length !== 1 || parsed.select[0].type !== 'function') {
            throw new ValidationError(400, 'Invalid query. Function not found or not supported');
Severity: Minor
Found in app/src/services/query.service.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function isQuery has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static async isQuery(tableName, parsed, sql, ctx, endpoint) {
        logger.debug('Is query');
        let datasetId = ctx.params.dataset || tableName;
        if (parsed.from && !datasetId) {
            datasetId = parsed.from.replace(/"/g, '').replace(/'/g, '');
Severity: Major
Found in app/src/services/query.service.js - About 3 hrs to fix

    Function isQuery has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        static async isQuery(tableName, parsed, sql, ctx, endpoint) {
        logger.debug('Is query');
        let datasetId = ctx.params.dataset || tableName;
        if (parsed.from && !datasetId) {
            datasetId = parsed.from.replace(/"/g, '').replace(/'/g, '');
    Severity: Minor
    Found in app/src/services/query.service.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function isFunction has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static isFunction(parsed) {
        logger.debug('Checking if it is a function', parsed);

        if (!parsed.select || parsed.select.length !== 1 || parsed.select[0].type !== 'function') {
            throw new ValidationError(400, 'Invalid query. Function not found or not supported');
    Severity: Major
    Found in app/src/services/query.service.js - About 2 hrs to fix

      Function checkUserHasPermission has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      const checkUserHasPermission = (user, dataset) => {
    if (user && dataset) {
        // check if user is admin of any application of the dataset or manager and owner of the dataset
        if (user.role === 'MANAGER' && user.id === dataset.userId) {
            return true;
      Severity: Minor
      Found in app/src/services/query.service.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                  } else if (arg.location === 'body') {
                if (!body[arg.name]) {
                    body[arg.name] = argFun.value;
                } else {
                    body[arg.name] += `,${argFun.value}`;
      Severity: Major
      Found in app/src/services/query.service.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        if (!qs[arg.name]) {
                    qs[arg.name] = argFun.value;
                } else {
                    qs[arg.name] += `,${argFun.value}`;
                }
        Severity: Major
        Found in app/src/services/query.service.js - About 45 mins to fix

          Function containApps has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          const containApps = (apps1, apps2) => {
    if (!apps1 || !apps2) {
        return false;
    }
    for (let i = 0, { length } = apps1; i < length; i++) {
          Severity: Minor
          Found in app/src/services/query.service.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getTargetQuery has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              static async getTargetQuery(ctx, endpoint) {
        logger.debug('Obtaining target query');
        const sql = ctx.query.sql || ctx.request.body.sql;
        const tableName = ctx.query.tableName || ctx.request.body.tableName;
        let parsed = null;
          Severity: Minor
          Found in app/src/services/query.service.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      } else if (arg.location === 'query') {
                if (!qs[arg.name]) {
                    qs[arg.name] = argFun.value;
                } else {
                    qs[arg.name] += `,${argFun.value}`;
          Severity: Major
          Found in app/src/services/query.service.js and 2 other locations - About 1 hr to fix
          app/src/services/query.service.js on lines 111..129
          app/src/services/query.service.js on lines 123..129

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 72.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      } else if (arg.location === 'body') {
                if (!body[arg.name]) {
                    body[arg.name] = argFun.value;
                } else {
                    body[arg.name] += `,${argFun.value}`;
          Severity: Major
          Found in app/src/services/query.service.js and 2 other locations - About 1 hr to fix
          app/src/services/query.service.js on lines 111..129
          app/src/services/query.service.js on lines 117..129

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 72.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      } else if (arg.location === 'path') {
                if (!path[arg.name]) {
                    path[arg.name] = argFun.value;
                } else {
                    path[arg.name] += `,${argFun.value}`;
          Severity: Major
          Found in app/src/services/query.service.js and 2 other locations - About 1 hr to fix
          app/src/services/query.service.js on lines 117..129
          app/src/services/query.service.js on lines 123..129

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 72.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status