Showing 7 of 9 total issues
Method unitalic
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
def unitalic(math)
math.xpath(".//xmlns:r[xmlns:rPr[not(xmlns:scr)]/xmlns:sty[@m:val = 'p']]").each do |x|
x.wrap("<span #{HTML_NS} style='font-style:normal;'></span>")
end
math.xpath(".//xmlns:r[xmlns:rPr[not(xmlns:scr)]/xmlns:sty[@m:val = 'bi']]").each do |x|
Method image_cleanup
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def image_cleanup(docxml, dir, localdir)
docxml.traverse do |i|
src = i["src"]
next unless i.element? && %w(img v:imagedata).include?(i.name)
next if src.nil? || src.empty? || /^http/.match?(src)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method list2para
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def list2para(list)
return if list.xpath("./li").empty?
list2para_position(list)
list.xpath("./li").each do |l|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method progress_conv
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def progress_conv(idx, step, total, threshold, msg)
Method image_resize
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def image_resize(img, path, maxheight, maxwidth)
s, realsize = get_image_size(img, path)
return s if s[0] == nil && s[1] == nil
if img.name == "svg" && !img["viewBox"]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method contentid
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def contentid(mhtml)
mhtml.gsub %r{(<img[^>]*?src=")([^"']+)(['"])}m do |m|
repl = "#{$1}cid:#{File.basename($2)}#{$3}"
/^data:|^https?:/ =~ $2 ? m : repl
end.gsub %r{(<v:imagedata[^>]*?src=")([^"']+)(['"])}m do |m|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method bookmarks
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def bookmarks(docxml)
docxml.xpath("//*[@id][not(@name)][not(@style = 'mso-element:footnote')]")
.each do |x|
next if x["id"].empty? ||
%w(shapetype v:shapetype shape v:shape).include?(x.name)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"