richardcarls/passport-indieauth

View on GitHub

Showing 7 of 15 total issues

Function authenticate has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

Strategy.prototype.authenticate = function(req, options) {

  var requestParams = {};
  var authEndpoint;
  var tokenEndpoint;
Severity: Minor
Found in lib/strategy.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function authenticate has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Strategy.prototype.authenticate = function(req, options) {

  var requestParams = {};
  var authEndpoint;
  var tokenEndpoint;
Severity: Major
Found in lib/strategy.js - About 3 hrs to fix

    Function parseUserPageCB has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      parseUserPage(requestParams.me, function parseUserPageCB(err, mfData) {
        if (err) { return strategy.fail({ message: err.message, }); }
    
        if (mfData.rels && mfData.rels.authorization_endpoint) {
          // Get discovered authorization endpoint
    Severity: Major
    Found in lib/strategy.js - About 2 hrs to fix

      Function convertToProfile has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function convertToProfile(mfData) {
        var profile;
        var properties;
      
        profile = {
      Severity: Major
      Found in lib/strategy.js - About 2 hrs to fix

        Function IndieAuthStrategy has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        function IndieAuthStrategy(options, verify) {
        
          /**
           * The verify callback
           *
        Severity: Minor
        Found in lib/strategy.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function IndieAuthStrategy has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function IndieAuthStrategy(options, verify) {
        
          /**
           * The verify callback
           *
        Severity: Minor
        Found in lib/strategy.js - About 1 hr to fix

          Function verifyAuthCode has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function verifyAuthCode(url, params, callback) {
          
            /**
             * The verifyAuthCode callback
             *
          Severity: Minor
          Found in lib/strategy.js - About 1 hr to fix
            Severity
            Category
            Status
            Source
            Language