rikkeisoft/sonar-rules

View on GitHub

Showing 4 of 275 total issues

Function execute has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        /** @var \GuzzleHttp\Client $client */
        $client = $this->getContainer()['http-client'];
        $language = $input->getArgument('language');
Severity: Minor
Found in src/Commands/ListRulesCommand.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        /** @var \GuzzleHttp\Client $client */
        $client = $this->getContainer()['http-client'];
        $language = $input->getArgument('language');
Severity: Major
Found in src/Commands/ListRulesCommand.php - About 2 hrs to fix

    Avoid too many return statements within this method.
    Open

            return 0;
    Severity: Major
    Found in src/Commands/ListRulesCommand.php - About 30 mins to fix

      Function createCsv has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function createCsv($data, $language)
          {
              ob_start();
      
              $resource = fopen('php://output', 'w');
      Severity: Minor
      Found in src/Commands/ListRulesCommand.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language