Sign upLogin

rimiti/keldoc-js-sdk

View on GitHub
Star
src/classes/common.js

Summary

Maintainability
C
1 day
Test Coverage

Function httpStatus has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Invalid

  static httpStatus(response: { status: number }): any {
    if (response.status === 400) return new BadRequest();
    if (response.status === 401) return new Unauthorized();
    if (response.status === 402) return new OverQuota();
    if (response.status === 404) return new NotFound();
Severity: Minor
Found in src/classes/common.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    if (response.status === 406) return new NotAcceptable();
Severity: Major
Found in src/classes/common.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        if (response.status === 500) return new InternalError();
    Severity: Major
    Found in src/classes/common.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Invalid

          return new UnknownError();
      Severity: Major
      Found in src/classes/common.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            if (response.status === 422) return new ValidationError();
        Severity: Major
        Found in src/classes/common.js - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            postRequest(url: string, body: any): Promise<any> {
    return new Promise((resolve, reject) => {
      this.generateHeader();
      axios.post(this.configuration.host + url, body)
        .then((response: {}) => resolve(response))
          Severity: Major
          Found in src/classes/common.js and 1 other location - About 4 hrs to fix
          src/classes/common.js on lines 95..102

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 132.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            putRequest(url: string, body: any): Promise<any> {
    return new Promise((resolve, reject) => {
      this.generateHeader();
      axios.put(this.configuration.host + url, body)
        .then((response: {}) => resolve(response))
          Severity: Major
          Found in src/classes/common.js and 1 other location - About 4 hrs to fix
          src/classes/common.js on lines 80..87

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 132.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status