Sign upLogin

rinvex/laravel-categories

View on GitHub
Star

Showing 3 of 6 total issues

Function prepareCategoryIds has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    protected function prepareCategoryIds($categories): array
    {
        // Convert collection to plain array
        if ($categories instanceof BaseCollection && is_string($categories->first())) {
            $categories = $categories->toArray();
Severity: Minor
Found in src/Traits/Categorizable.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method morphToMany has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $related,
        $name,
        $table = null,
        $foreignPivotKey = null,
        $relatedPivotKey = null,
Severity: Major
Found in src/Traits/Categorizable.php - About 1 hr to fix

Avoid too many return statements within this method.
Open

        return (array) $categories;
Severity: Major
Found in src/Traits/Categorizable.php - About 30 mins to fix
Severity
Category
Status
Source
Language