Sign upLogin

ripple/ripple-rest

View on GitHub
Star
api/orders.js

Summary

Maintainability
F
3 days
Test Coverage

Function getOrderBook has 118 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getOrderBook(account, base, counter, options, callback) {
  var self = this;

  var params = _.merge(options, {
    validated: true,
Severity: Major
Found in api/orders.js - About 4 hrs to fix

    Function getOrders has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function getOrders(account, options, callback) {
  var self = this;

  validate.address(account);
  validate.options(options);
    Severity: Major
    Found in api/orders.js - About 2 hrs to fix

      File orders.js has 252 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* globals Promise: true */
/* eslint-disable valid-jsdoc */
'use strict';
var _ = require('lodash');
var asyncify = require('simple-asyncify');
      Severity: Minor
      Found in api/orders.js - About 2 hrs to fix

        Function getOrders has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

        function getOrders(account, options, callback) {
  var self = this;

  validate.address(account);
  validate.options(options);
        Severity: Minor
        Found in api/orders.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getParsedBookOffers has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function getParsedBookOffers(offers, isAsk) {
    return offers.reduce(function(orderBook, off) {
      var price;
      var order_maker = off.Account;
      var sequence = off.Sequence;
        Severity: Minor
        Found in api/orders.js - About 1 hr to fix

          Function getAccountOrders has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function getAccountOrders(prevResult) {
    var isAggregate = options.limit === 'all';
    if (prevResult && (!isAggregate || !prevResult.marker)) {
      return Promise.resolve(prevResult);
    }
          Severity: Minor
          Found in api/orders.js - About 1 hr to fix

            Function promise has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                var promise = new Promise(function(resolve, reject) {
      var accountOrdersRequest;
      var marker;
      var ledger;
      var limit;
            Severity: Minor
            Found in api/orders.js - About 1 hr to fix

              Function cancelOrder has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function cancelOrder(account, sequence, secret, options, callback) {
              Severity: Minor
              Found in api/orders.js - About 35 mins to fix

                Function getOrderBook has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function getOrderBook(account, base, counter, options, callback) {
                Severity: Minor
                Found in api/orders.js - About 35 mins to fix

                  Function placeOrder has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  function placeOrder(account, order, secret, options, callback) {
                  Severity: Minor
                  Found in api/orders.js - About 35 mins to fix

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                          if (prevResult) {
        marker = prevResult.marker;
        limit = prevResult.limit;
        ledger = prevResult.ledger_index;
      } else {
                    Severity: Major
                    Found in api/orders.js and 2 other locations - About 3 hrs to fix
                    api/balances.js on lines 81..90
                    api/trustlines.js on lines 58..67

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 108.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          } else {
        price = {
          currency: taker_gets_total.currency,
          counterparty: taker_gets_total.counterparty,
          value: bignum(taker_gets_total.value).div(
                    Severity: Major
                    Found in api/orders.js and 1 other location - About 1 hr to fix
                    api/orders.js on lines 295..302

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 58.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          if (isAsk) {
        price = {
          currency: taker_pays_total.currency,
          counterparty: taker_pays_total.counterparty,
          value: bignum(taker_pays_total.value).div(
                    Severity: Major
                    Found in api/orders.js and 1 other location - About 1 hr to fix
                    api/orders.js on lines 302..309

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 58.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    function cancelOrder(account, sequence, secret, options, callback) {
  var transaction = createOrderCancellationTransaction(account, sequence);
  var converter = TxToRestConverter.parseCancelOrderFromTx;
  transact(transaction, this, secret, options, converter, callback);
}
                    Severity: Minor
                    Found in api/orders.js and 1 other location - About 50 mins to fix
                    api/orders.js on lines 162..166

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 52.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    function placeOrder(account, order, secret, options, callback) {
  var transaction = createOrderTransaction(account, order);
  var converter = TxToRestConverter.parseSubmitOrderFromTx;
  transact(transaction, this, secret, options, converter, callback);
}
                    Severity: Minor
                    Found in api/orders.js and 1 other location - About 50 mins to fix
                    api/orders.js on lines 180..184

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 52.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status