rkokkelk/siso

View on GitHub

Showing 4 of 22 total issues

Method decrypt_aes_256 has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def decrypt_aes_256(iv, key, data, encode = true, auth_data = '')
Severity: Minor
Found in app/helpers/crypto_helper.rb - About 35 mins to fix

    Method encrypt_aes_256 has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def encrypt_aes_256(iv, key, data, encode = true, auth_data = '')
    Severity: Minor
    Found in app/helpers/crypto_helper.rb - About 35 mins to fix

      Method verifyIP has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def verifyIP(ip)
          unless @@ranges
            Rails.logger.error { "Cannot verify IP, @ranges(#{@@ranges})" }
            return false
          end
      Severity: Minor
      Found in app/helpers/ip_helper.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method clear_old_repositories has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def clear_old_repositories
          repositories = Repository.all
      
          repositories.each do |repository|
            next unless repository.deleted_at.past?
      Severity: Minor
      Found in app/helpers/repositories_helper.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language