Sign upLogin

robertgauld/OSMExtender

View on GitHub
Star
app/assets/javascripts/application/passwords.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function getPasswordTips has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

function getPasswordTips(password) {
    if ((password.length >= 1) && (passwordHaystackSize(password) < minimum_haystack_size)) {
        tips = "\n<ul>";
        if (password.match(/[A-Z]/) == null)
            tips += '<li>Try adding some uppercase letters</li>';
Severity: Minor
Found in app/assets/javascripts/application/passwords.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    if (strength < 10000) {return "Strong" }
Severity: Major
Found in app/assets/javascripts/application/passwords.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return "Very strong"
    Severity: Major
    Found in app/assets/javascripts/application/passwords.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          if (strength < 10000) {return "#55ff55" }
      Severity: Major
      Found in app/assets/javascripts/application/passwords.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return "#22ff22"
        Severity: Major
        Found in app/assets/javascripts/application/passwords.js - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          function getPasswordStrengthColor(strength) {
    if (strength < 0.000002) {return "#ff2222" }
    if (strength < 0.002) {return "#ff5555" }
    if (strength < 1) {return "#ff8888" }
    if (strength < 10) {return "#99ff99" }
          Severity: Major
          Found in app/assets/javascripts/application/passwords.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/application/passwords.js on lines 25..32

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          function getPasswordStrengthDescription(strength) {
    if (strength < 0.000002) {return "Very weak" }
    if (strength < 0.002) {return "Weak" }
    if (strength < 1) {return "Nearly strong enough" }
    if (strength < 10) {return "Strong enough" }
          Severity: Major
          Found in app/assets/javascripts/application/passwords.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/application/passwords.js on lines 16..23

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status