Showing 146 of 184 total issues
Method get_for_section has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def self.get_for_section(api, section, options={})
section_id = section.to_i
require_ability_to(api, :read, :member, section, options)
cache_key = ['myscout', 'parent_login_history', section_id]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def self.get(api, section_id, options={})
cache_key = ['section', section_id]
if !options[:no_cache] && cache_exist?(api, cache_key) && can_access_section?(api, section_id)
return cache_read(api, cache_key)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def update(api)
raise Osm::ObjectIsInvalid, 'grouping is invalid' unless valid?
require_ability_to(api, :read, :member, section_id)
to_update = changed_attributes- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add_column has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def add_column(api, name)
require_ability_to(api, :write, :flexi, section_id)
raise ArgumentError, 'name is invalid' if name.blank?
data = api.perform_query("extras.php?action=addColumn§ionid=#{section_id}&extraid=#{id}", {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method parse_date has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def self.parse_date(date, options={})
return nil if date.nil? || date.empty? || (!options[:ignore_epoch] && epoch_date?(date))
begin
return Date.strptime(date, (date.include?('-') ? OSM_DATE_FORMAT : OSM_DATE_FORMAT_HUMAN))
rescue ArgumentError- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method gained_in_modules has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def gained_in_modules
count = {}
badge.modules.each do |mod|
count[mod.id] ||= 0
count[mod.letter] ||= 0- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"