src/require/createResolveRequest.js

Summary

Maintainability
D
2 days
Test Coverage

Function createResolveRequest has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

export default function createResolveRequest(exports, directory, dependencyContext) {
    const log = require('debug')('roc:core:require'); // eslint-disable-line

    const contextCache = {};
    // Matches a module request, getting the module and a possible scope
Severity: Minor
Found in src/require/createResolveRequest.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createResolveRequest has 133 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function createResolveRequest(exports, directory, dependencyContext) {
    const log = require('debug')('roc:core:require'); // eslint-disable-line

    const contextCache = {};
    // Matches a module request, getting the module and a possible scope
Severity: Major
Found in src/require/createResolveRequest.js - About 5 hrs to fix

    Function resolveRequestAsync has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function resolveRequestAsync(identifier = 'No identifier') {
            const resolveCache = {};
            const defaultResolver = (request, context, callback) => resolve(request, { basedir: context }, callback);
            const completeResolve = (callback, request, module) => (error, newRequest) => {
                if (error) {
    Severity: Minor
    Found in src/require/createResolveRequest.js - About 1 hr to fix

      Function resolveRequest has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function resolveRequest(identifier = 'No identifier') {
              const resolveCache = {};
              const defaultResolver = (request, context) => resolve.sync(request, { basedir: context });
      
              const resolveRequestHelper = (request, context, fallback = false, resolver = defaultResolver) => {
      Severity: Minor
      Found in src/require/createResolveRequest.js - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

                return {
                    module,
                    rocContext: rocContext[module],
                };
        Severity: Major
        Found in src/require/createResolveRequest.js - About 30 mins to fix

          Expected to return a value at the end of arrow function.
          Open

                  const resolveRequestHelper = (request, context, fallback = false, resolver = defaultResolver, callback) => {
          Severity: Minor
          Found in src/require/createResolveRequest.js by eslint

          require return statements to either always or never specify values (consistent-return)

          Unlike statically-typed languages which enforce that a function returns a specified type of value, JavaScript allows different code paths in a function to return different types of values.

          A confusing aspect of JavaScript is that a function returns undefined if any of the following are true:

          • it does not execute a return statement before it exits
          • it executes return which does not specify a value explicitly
          • it executes return undefined
          • it executes return void followed by an expression (for example, a function call)
          • it executes return followed by any other expression which evaluates to undefined

          If any code paths in a function return a value explicitly but some code path do not return a value explicitly, it might be a typing mistake, especially in a large function. In the following example:

          • a code path through the function returns a Boolean value true
          • another code path does not return a value explicitly, therefore returns undefined implicitly
          function doSomething(condition) {
              if (condition) {
                  return true;
              } else {
                  return;
              }
          }

          Rule Details

          This rule requires return statements to either always or never specify values. This rule ignores function definitions where the name begins with an uppercase letter, because constructors (when invoked with the new operator) return the instantiated object implicitly if they do not return another object explicitly.

          Examples of incorrect code for this rule:

          /*eslint consistent-return: "error"*/
          
          function doSomething(condition) {
              if (condition) {
                  return true;
              } else {
                  return;
              }
          }
          
          function doSomething(condition) {
              if (condition) {
                  return true;
              }
          }

          Examples of correct code for this rule:

          /*eslint consistent-return: "error"*/
          
          function doSomething(condition) {
              if (condition) {
                  return true;
              } else {
                  return false;
              }
          }
          
          function Foo() {
              if (!(this instanceof Foo)) {
                  return new Foo();
              }
          
              this.a = 0;
          }

          Options

          This rule has an object option:

          • "treatUndefinedAsUnspecified": false (default) always either specify values or return undefined implicitly only.
          • "treatUndefinedAsUnspecified": true always either specify values or return undefined explicitly or implicitly.

          treatUndefinedAsUnspecified

          Examples of incorrect code for this rule with the default { "treatUndefinedAsUnspecified": false } option:

          /*eslint consistent-return: ["error", { "treatUndefinedAsUnspecified": false }]*/
          
          function foo(callback) {
              if (callback) {
                  return void callback();
              }
              // no return statement
          }
          
          function bar(condition) {
              if (condition) {
                  return undefined;
              }
              // no return statement
          }

          Examples of incorrect code for this rule with the { "treatUndefinedAsUnspecified": true } option:

          /*eslint consistent-return: ["error", { "treatUndefinedAsUnspecified": true }]*/
          
          function foo(callback) {
              if (callback) {
                  return void callback();
              }
              return true;
          }
          
          function bar(condition) {
              if (condition) {
                  return undefined;
              }
              return true;
          }

          Examples of correct code for this rule with the { "treatUndefinedAsUnspecified": true } option:

          /*eslint consistent-return: ["error", { "treatUndefinedAsUnspecified": true }]*/
          
          function foo(callback) {
              if (callback) {
                  return void callback();
              }
              // no return statement
          }
          
          function bar(condition) {
              if (condition) {
                  return undefined;
              }
              // no return statement
          }

          When Not To Use It

          If you want to allow functions to have different return behavior depending on code branching, then it is safe to disable this rule. Source: http://eslint.org/docs/rules/

          Expected to return a value at the end of arrow function.
          Open

                  ) => {
          Severity: Minor
          Found in src/require/createResolveRequest.js by eslint

          require return statements to either always or never specify values (consistent-return)

          Unlike statically-typed languages which enforce that a function returns a specified type of value, JavaScript allows different code paths in a function to return different types of values.

          A confusing aspect of JavaScript is that a function returns undefined if any of the following are true:

          • it does not execute a return statement before it exits
          • it executes return which does not specify a value explicitly
          • it executes return undefined
          • it executes return void followed by an expression (for example, a function call)
          • it executes return followed by any other expression which evaluates to undefined

          If any code paths in a function return a value explicitly but some code path do not return a value explicitly, it might be a typing mistake, especially in a large function. In the following example:

          • a code path through the function returns a Boolean value true
          • another code path does not return a value explicitly, therefore returns undefined implicitly
          function doSomething(condition) {
              if (condition) {
                  return true;
              } else {
                  return;
              }
          }

          Rule Details

          This rule requires return statements to either always or never specify values. This rule ignores function definitions where the name begins with an uppercase letter, because constructors (when invoked with the new operator) return the instantiated object implicitly if they do not return another object explicitly.

          Examples of incorrect code for this rule:

          /*eslint consistent-return: "error"*/
          
          function doSomething(condition) {
              if (condition) {
                  return true;
              } else {
                  return;
              }
          }
          
          function doSomething(condition) {
              if (condition) {
                  return true;
              }
          }

          Examples of correct code for this rule:

          /*eslint consistent-return: "error"*/
          
          function doSomething(condition) {
              if (condition) {
                  return true;
              } else {
                  return false;
              }
          }
          
          function Foo() {
              if (!(this instanceof Foo)) {
                  return new Foo();
              }
          
              this.a = 0;
          }

          Options

          This rule has an object option:

          • "treatUndefinedAsUnspecified": false (default) always either specify values or return undefined implicitly only.
          • "treatUndefinedAsUnspecified": true always either specify values or return undefined explicitly or implicitly.

          treatUndefinedAsUnspecified

          Examples of incorrect code for this rule with the default { "treatUndefinedAsUnspecified": false } option:

          /*eslint consistent-return: ["error", { "treatUndefinedAsUnspecified": false }]*/
          
          function foo(callback) {
              if (callback) {
                  return void callback();
              }
              // no return statement
          }
          
          function bar(condition) {
              if (condition) {
                  return undefined;
              }
              // no return statement
          }

          Examples of incorrect code for this rule with the { "treatUndefinedAsUnspecified": true } option:

          /*eslint consistent-return: ["error", { "treatUndefinedAsUnspecified": true }]*/
          
          function foo(callback) {
              if (callback) {
                  return void callback();
              }
              return true;
          }
          
          function bar(condition) {
              if (condition) {
                  return undefined;
              }
              return true;
          }

          Examples of correct code for this rule with the { "treatUndefinedAsUnspecified": true } option:

          /*eslint consistent-return: ["error", { "treatUndefinedAsUnspecified": true }]*/
          
          function foo(callback) {
              if (callback) {
                  return void callback();
              }
              // no return statement
          }
          
          function bar(condition) {
              if (condition) {
                  return undefined;
              }
              // no return statement
          }

          When Not To Use It

          If you want to allow functions to have different return behavior depending on code branching, then it is safe to disable this rule. Source: http://eslint.org/docs/rules/

          Missing trailing comma.
          Open

                      } = {}
          Severity: Minor
          Found in src/require/createResolveRequest.js by eslint

          require or disallow trailing commas (comma-dangle)

          Trailing commas in object literals are valid according to the ECMAScript 5 (and ECMAScript 3!) spec. However, IE8 (when not in IE8 document mode) and below will throw an error when it encounters trailing commas in JavaScript.

          var foo = {
              bar: "baz",
              qux: "quux",
          };

          Trailing commas simplify adding and removing items to objects and arrays, since only the lines you are modifying must be touched. Another argument in favor of trailing commas is that it improves the clarity of diffs when an item is added or removed from an object or array:

          Less clear:

          var foo = {
          -    bar: "baz",
          -    qux: "quux"
          +    bar: "baz"
           };

          More clear:

          var foo = {
               bar: "baz",
          -    qux: "quux",
           };

          Rule Details

          This rule enforces consistent use of trailing commas in object and array literals.

          Options

          This rule has a string option or an object option:

          {
              "comma-dangle": ["error", "never"],
              // or
              "comma-dangle": ["error", {
                  "arrays": "never",
                  "objects": "never",
                  "imports": "never",
                  "exports": "never",
                  "functions": "ignore",
              }]
          }
          • "never" (default) disallows trailing commas
          • "always" requires trailing commas
          • "always-multiline" requires trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }
          • "only-multiline" allows (but does not require) trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }

          Trailing commas in function declarations and function calls are valid syntax since ECMAScript 2017; however, the string option does not check these situations for backwards compatibility.

          You can also use an object option to configure this rule for each type of syntax. Each of the following options can be set to "never", "always", "always-multiline", "only-multiline", or "ignore". The default for each option is "never" unless otherwise specified.

          • arrays is for array literals and array patterns of destructuring. (e.g. let [a,] = [1,];)
          • objects is for object literals and object patterns of destructuring. (e.g. let {a,} = {a: 1};)
          • imports is for import declarations of ES Modules. (e.g. import {a,} from "foo";)
          • exports is for export declarations of ES Modules. (e.g. export {a,};)
          • functions is for function declarations and function calls. (e.g. (function(a,){ })(b,);)
            functions is set to "ignore" by default for consistency with the string option.

          never

          Examples of incorrect code for this rule with the default "never" option:

          /*eslint comma-dangle: ["error", "never"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux",
          };
          
          var arr = [1,2,];
          
          foo({
            bar: "baz",
            qux: "quux",
          });

          Examples of correct code for this rule with the default "never" option:

          /*eslint comma-dangle: ["error", "never"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux"
          };
          
          var arr = [1,2];
          
          foo({
            bar: "baz",
            qux: "quux"
          });

          always

          Examples of incorrect code for this rule with the "always" option:

          /*eslint comma-dangle: ["error", "always"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux"
          };
          
          var arr = [1,2];
          
          foo({
            bar: "baz",
            qux: "quux"
          });

          Examples of correct code for this rule with the "always" option:

          /*eslint comma-dangle: ["error", "always"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux",
          };
          
          var arr = [1,2,];
          
          foo({
            bar: "baz",
            qux: "quux",
          });

          always-multiline

          Examples of incorrect code for this rule with the "always-multiline" option:

          /*eslint comma-dangle: ["error", "always-multiline"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux"
          };
          
          var foo = { bar: "baz", qux: "quux", };
          
          var arr = [1,2,];
          
          var arr = [1,
              2,];
          
          var arr = [
              1,
              2
          ];
          
          foo({
            bar: "baz",
            qux: "quux"
          });

          Examples of correct code for this rule with the "always-multiline" option:

          /*eslint comma-dangle: ["error", "always-multiline"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux",
          };
          
          var foo = {bar: "baz", qux: "quux"};
          var arr = [1,2];
          
          var arr = [1,
              2];
          
          var arr = [
              1,
              2,
          ];
          
          foo({
            bar: "baz",
            qux: "quux",
          });

          only-multiline

          Examples of incorrect code for this rule with the "only-multiline" option:

          /*eslint comma-dangle: ["error", "only-multiline"]*/
          
          var foo = { bar: "baz", qux: "quux", };
          
          var arr = [1,2,];
          
          var arr = [1,
              2,];

          Examples of correct code for this rule with the "only-multiline" option:

          /*eslint comma-dangle: ["error", "only-multiline"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux",
          };
          
          var foo = {
              bar: "baz",
              qux: "quux"
          };
          
          var foo = {bar: "baz", qux: "quux"};
          var arr = [1,2];
          
          var arr = [1,
              2];
          
          var arr = [
              1,
              2,
          ];
          
          var arr = [
              1,
              2
          ];
          
          foo({
            bar: "baz",
            qux: "quux",
          });
          
          foo({
            bar: "baz",
            qux: "quux"
          });

          functions

          Examples of incorrect code for this rule with the {"functions": "never"} option:

          /*eslint comma-dangle: ["error", {"functions": "never"}]*/
          
          function foo(a, b,) {
          }
          
          foo(a, b,);
          new foo(a, b,);

          Examples of correct code for this rule with the {"functions": "never"} option:

          /*eslint comma-dangle: ["error", {"functions": "never"}]*/
          
          function foo(a, b) {
          }
          
          foo(a, b);
          new foo(a, b);

          Examples of incorrect code for this rule with the {"functions": "always"} option:

          /*eslint comma-dangle: ["error", {"functions": "always"}]*/
          
          function foo(a, b) {
          }
          
          foo(a, b);
          new foo(a, b);

          Examples of correct code for this rule with the {"functions": "always"} option:

          /*eslint comma-dangle: ["error", {"functions": "always"}]*/
          
          function foo(a, b,) {
          }
          
          foo(a, b,);
          new foo(a, b,);

          When Not To Use It

          You can turn this rule off if you are not concerned with dangling commas. Source: http://eslint.org/docs/rules/

          Missing trailing comma.
          Open

                  initGetDependenciesFromPath(dependencyContext)
          Severity: Minor
          Found in src/require/createResolveRequest.js by eslint

          require or disallow trailing commas (comma-dangle)

          Trailing commas in object literals are valid according to the ECMAScript 5 (and ECMAScript 3!) spec. However, IE8 (when not in IE8 document mode) and below will throw an error when it encounters trailing commas in JavaScript.

          var foo = {
              bar: "baz",
              qux: "quux",
          };

          Trailing commas simplify adding and removing items to objects and arrays, since only the lines you are modifying must be touched. Another argument in favor of trailing commas is that it improves the clarity of diffs when an item is added or removed from an object or array:

          Less clear:

          var foo = {
          -    bar: "baz",
          -    qux: "quux"
          +    bar: "baz"
           };

          More clear:

          var foo = {
               bar: "baz",
          -    qux: "quux",
           };

          Rule Details

          This rule enforces consistent use of trailing commas in object and array literals.

          Options

          This rule has a string option or an object option:

          {
              "comma-dangle": ["error", "never"],
              // or
              "comma-dangle": ["error", {
                  "arrays": "never",
                  "objects": "never",
                  "imports": "never",
                  "exports": "never",
                  "functions": "ignore",
              }]
          }
          • "never" (default) disallows trailing commas
          • "always" requires trailing commas
          • "always-multiline" requires trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }
          • "only-multiline" allows (but does not require) trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }

          Trailing commas in function declarations and function calls are valid syntax since ECMAScript 2017; however, the string option does not check these situations for backwards compatibility.

          You can also use an object option to configure this rule for each type of syntax. Each of the following options can be set to "never", "always", "always-multiline", "only-multiline", or "ignore". The default for each option is "never" unless otherwise specified.

          • arrays is for array literals and array patterns of destructuring. (e.g. let [a,] = [1,];)
          • objects is for object literals and object patterns of destructuring. (e.g. let {a,} = {a: 1};)
          • imports is for import declarations of ES Modules. (e.g. import {a,} from "foo";)
          • exports is for export declarations of ES Modules. (e.g. export {a,};)
          • functions is for function declarations and function calls. (e.g. (function(a,){ })(b,);)
            functions is set to "ignore" by default for consistency with the string option.

          never

          Examples of incorrect code for this rule with the default "never" option:

          /*eslint comma-dangle: ["error", "never"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux",
          };
          
          var arr = [1,2,];
          
          foo({
            bar: "baz",
            qux: "quux",
          });

          Examples of correct code for this rule with the default "never" option:

          /*eslint comma-dangle: ["error", "never"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux"
          };
          
          var arr = [1,2];
          
          foo({
            bar: "baz",
            qux: "quux"
          });

          always

          Examples of incorrect code for this rule with the "always" option:

          /*eslint comma-dangle: ["error", "always"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux"
          };
          
          var arr = [1,2];
          
          foo({
            bar: "baz",
            qux: "quux"
          });

          Examples of correct code for this rule with the "always" option:

          /*eslint comma-dangle: ["error", "always"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux",
          };
          
          var arr = [1,2,];
          
          foo({
            bar: "baz",
            qux: "quux",
          });

          always-multiline

          Examples of incorrect code for this rule with the "always-multiline" option:

          /*eslint comma-dangle: ["error", "always-multiline"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux"
          };
          
          var foo = { bar: "baz", qux: "quux", };
          
          var arr = [1,2,];
          
          var arr = [1,
              2,];
          
          var arr = [
              1,
              2
          ];
          
          foo({
            bar: "baz",
            qux: "quux"
          });

          Examples of correct code for this rule with the "always-multiline" option:

          /*eslint comma-dangle: ["error", "always-multiline"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux",
          };
          
          var foo = {bar: "baz", qux: "quux"};
          var arr = [1,2];
          
          var arr = [1,
              2];
          
          var arr = [
              1,
              2,
          ];
          
          foo({
            bar: "baz",
            qux: "quux",
          });

          only-multiline

          Examples of incorrect code for this rule with the "only-multiline" option:

          /*eslint comma-dangle: ["error", "only-multiline"]*/
          
          var foo = { bar: "baz", qux: "quux", };
          
          var arr = [1,2,];
          
          var arr = [1,
              2,];

          Examples of correct code for this rule with the "only-multiline" option:

          /*eslint comma-dangle: ["error", "only-multiline"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux",
          };
          
          var foo = {
              bar: "baz",
              qux: "quux"
          };
          
          var foo = {bar: "baz", qux: "quux"};
          var arr = [1,2];
          
          var arr = [1,
              2];
          
          var arr = [
              1,
              2,
          ];
          
          var arr = [
              1,
              2
          ];
          
          foo({
            bar: "baz",
            qux: "quux",
          });
          
          foo({
            bar: "baz",
            qux: "quux"
          });

          functions

          Examples of incorrect code for this rule with the {"functions": "never"} option:

          /*eslint comma-dangle: ["error", {"functions": "never"}]*/
          
          function foo(a, b,) {
          }
          
          foo(a, b,);
          new foo(a, b,);

          Examples of correct code for this rule with the {"functions": "never"} option:

          /*eslint comma-dangle: ["error", {"functions": "never"}]*/
          
          function foo(a, b) {
          }
          
          foo(a, b);
          new foo(a, b);

          Examples of incorrect code for this rule with the {"functions": "always"} option:

          /*eslint comma-dangle: ["error", {"functions": "always"}]*/
          
          function foo(a, b) {
          }
          
          foo(a, b);
          new foo(a, b);

          Examples of correct code for this rule with the {"functions": "always"} option:

          /*eslint comma-dangle: ["error", {"functions": "always"}]*/
          
          function foo(a, b,) {
          }
          
          foo(a, b,);
          new foo(a, b,);

          When Not To Use It

          You can turn this rule off if you are not concerned with dangling commas. Source: http://eslint.org/docs/rules/

          Missing trailing comma.
          Open

                      callback
          Severity: Minor
          Found in src/require/createResolveRequest.js by eslint

          require or disallow trailing commas (comma-dangle)

          Trailing commas in object literals are valid according to the ECMAScript 5 (and ECMAScript 3!) spec. However, IE8 (when not in IE8 document mode) and below will throw an error when it encounters trailing commas in JavaScript.

          var foo = {
              bar: "baz",
              qux: "quux",
          };

          Trailing commas simplify adding and removing items to objects and arrays, since only the lines you are modifying must be touched. Another argument in favor of trailing commas is that it improves the clarity of diffs when an item is added or removed from an object or array:

          Less clear:

          var foo = {
          -    bar: "baz",
          -    qux: "quux"
          +    bar: "baz"
           };

          More clear:

          var foo = {
               bar: "baz",
          -    qux: "quux",
           };

          Rule Details

          This rule enforces consistent use of trailing commas in object and array literals.

          Options

          This rule has a string option or an object option:

          {
              "comma-dangle": ["error", "never"],
              // or
              "comma-dangle": ["error", {
                  "arrays": "never",
                  "objects": "never",
                  "imports": "never",
                  "exports": "never",
                  "functions": "ignore",
              }]
          }
          • "never" (default) disallows trailing commas
          • "always" requires trailing commas
          • "always-multiline" requires trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }
          • "only-multiline" allows (but does not require) trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }

          Trailing commas in function declarations and function calls are valid syntax since ECMAScript 2017; however, the string option does not check these situations for backwards compatibility.

          You can also use an object option to configure this rule for each type of syntax. Each of the following options can be set to "never", "always", "always-multiline", "only-multiline", or "ignore". The default for each option is "never" unless otherwise specified.

          • arrays is for array literals and array patterns of destructuring. (e.g. let [a,] = [1,];)
          • objects is for object literals and object patterns of destructuring. (e.g. let {a,} = {a: 1};)
          • imports is for import declarations of ES Modules. (e.g. import {a,} from "foo";)
          • exports is for export declarations of ES Modules. (e.g. export {a,};)
          • functions is for function declarations and function calls. (e.g. (function(a,){ })(b,);)
            functions is set to "ignore" by default for consistency with the string option.

          never

          Examples of incorrect code for this rule with the default "never" option:

          /*eslint comma-dangle: ["error", "never"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux",
          };
          
          var arr = [1,2,];
          
          foo({
            bar: "baz",
            qux: "quux",
          });

          Examples of correct code for this rule with the default "never" option:

          /*eslint comma-dangle: ["error", "never"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux"
          };
          
          var arr = [1,2];
          
          foo({
            bar: "baz",
            qux: "quux"
          });

          always

          Examples of incorrect code for this rule with the "always" option:

          /*eslint comma-dangle: ["error", "always"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux"
          };
          
          var arr = [1,2];
          
          foo({
            bar: "baz",
            qux: "quux"
          });

          Examples of correct code for this rule with the "always" option:

          /*eslint comma-dangle: ["error", "always"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux",
          };
          
          var arr = [1,2,];
          
          foo({
            bar: "baz",
            qux: "quux",
          });

          always-multiline

          Examples of incorrect code for this rule with the "always-multiline" option:

          /*eslint comma-dangle: ["error", "always-multiline"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux"
          };
          
          var foo = { bar: "baz", qux: "quux", };
          
          var arr = [1,2,];
          
          var arr = [1,
              2,];
          
          var arr = [
              1,
              2
          ];
          
          foo({
            bar: "baz",
            qux: "quux"
          });

          Examples of correct code for this rule with the "always-multiline" option:

          /*eslint comma-dangle: ["error", "always-multiline"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux",
          };
          
          var foo = {bar: "baz", qux: "quux"};
          var arr = [1,2];
          
          var arr = [1,
              2];
          
          var arr = [
              1,
              2,
          ];
          
          foo({
            bar: "baz",
            qux: "quux",
          });

          only-multiline

          Examples of incorrect code for this rule with the "only-multiline" option:

          /*eslint comma-dangle: ["error", "only-multiline"]*/
          
          var foo = { bar: "baz", qux: "quux", };
          
          var arr = [1,2,];
          
          var arr = [1,
              2,];

          Examples of correct code for this rule with the "only-multiline" option:

          /*eslint comma-dangle: ["error", "only-multiline"]*/
          
          var foo = {
              bar: "baz",
              qux: "quux",
          };
          
          var foo = {
              bar: "baz",
              qux: "quux"
          };
          
          var foo = {bar: "baz", qux: "quux"};
          var arr = [1,2];
          
          var arr = [1,
              2];
          
          var arr = [
              1,
              2,
          ];
          
          var arr = [
              1,
              2
          ];
          
          foo({
            bar: "baz",
            qux: "quux",
          });
          
          foo({
            bar: "baz",
            qux: "quux"
          });

          functions

          Examples of incorrect code for this rule with the {"functions": "never"} option:

          /*eslint comma-dangle: ["error", {"functions": "never"}]*/
          
          function foo(a, b,) {
          }
          
          foo(a, b,);
          new foo(a, b,);

          Examples of correct code for this rule with the {"functions": "never"} option:

          /*eslint comma-dangle: ["error", {"functions": "never"}]*/
          
          function foo(a, b) {
          }
          
          foo(a, b);
          new foo(a, b);

          Examples of incorrect code for this rule with the {"functions": "always"} option:

          /*eslint comma-dangle: ["error", {"functions": "always"}]*/
          
          function foo(a, b) {
          }
          
          foo(a, b);
          new foo(a, b);

          Examples of correct code for this rule with the {"functions": "always"} option:

          /*eslint comma-dangle: ["error", {"functions": "always"}]*/
          
          function foo(a, b,) {
          }
          
          foo(a, b,);
          new foo(a, b,);

          When Not To Use It

          You can turn this rule off if you are not concerned with dangling commas. Source: http://eslint.org/docs/rules/

          Unexpected parentheses around single function argument having a body with no curly braces
          Open

                          .find((name) => fallbackPattern.test(name));
          Severity: Minor
          Found in src/require/createResolveRequest.js by eslint

          Require parens in arrow function arguments (arrow-parens)

          Arrow functions can omit parentheses when they have exactly one parameter. In all other cases the parameter(s) must be wrapped in parentheses. This rule enforces the consistent use of parentheses in arrow functions.

          Rule Details

          This rule enforces parentheses around arrow function parameters regardless of arity. For example:

          /*eslint-env es6*/
          
          // Bad
          a => {}
          
          // Good
          (a) => {}

          Following this style will help you find arrow functions (=>) which may be mistakenly included in a condition when a comparison such as >= was the intent.

          /*eslint-env es6*/
          
          // Bad
          if (a => 2) {
          }
          
          // Good
          if (a >= 2) {
          }

          The rule can also be configured to discourage the use of parens when they are not required:

          /*eslint-env es6*/
          
          // Bad
          (a) => {}
          
          // Good
          a => {}

          Options

          This rule has a string option and an object one.

          String options are:

          • "always" (default) requires parens around arguments in all cases.
          • "as-needed" allows omitting parens when there is only one argument.

          Object properties for variants of the "as-needed" option:

          • "requireForBlockBody": true modifies the as-needed rule in order to require parens if the function body is in an instructions block (surrounded by braces).

          always

          Examples of incorrect code for this rule with the default "always" option:

          /*eslint arrow-parens: ["error", "always"]*/
          /*eslint-env es6*/
          
          a => {};
          a => a;
          a => {'\n'};
          a.then(foo => {});
          a.then(foo => a);
          a(foo => { if (true) {} });

          Examples of correct code for this rule with the default "always" option:

          /*eslint arrow-parens: ["error", "always"]*/
          /*eslint-env es6*/
          
          () => {};
          (a) => {};
          (a) => a;
          (a) => {'\n'}
          a.then((foo) => {});
          a.then((foo) => { if (true) {} });

          If Statements

          One of benefits of this option is that it prevents the incorrect use of arrow functions in conditionals:

          /*eslint-env es6*/
          
          var a = 1;
          var b = 2;
          // ...
          if (a => b) {
           console.log('bigger');
          } else {
           console.log('smaller');
          }
          // outputs 'bigger', not smaller as expected

          The contents of the if statement is an arrow function, not a comparison.

          If the arrow function is intentional, it should be wrapped in parens to remove ambiguity.

          /*eslint-env es6*/
          
          var a = 1;
          var b = 0;
          // ...
          if ((a) => b) {
           console.log('truthy value returned');
          } else {
           console.log('falsey value returned');
          }
          // outputs 'truthy value returned'

          The following is another example of this behavior:

          /*eslint-env es6*/
          
          var a = 1, b = 2, c = 3, d = 4;
          var f = a => b ? c: d;
          // f = ?

          f is an arrow function which takes a as an argument and returns the result of b ? c: d.

          This should be rewritten like so:

          /*eslint-env es6*/
          
          var a = 1, b = 2, c = 3, d = 4;
          var f = (a) => b ? c: d;

          as-needed

          Examples of incorrect code for this rule with the "as-needed" option:

          /*eslint arrow-parens: ["error", "as-needed"]*/
          /*eslint-env es6*/
          
          (a) => {};
          (a) => a;
          (a) => {'\n'};
          a.then((foo) => {});
          a.then((foo) => a);
          a((foo) => { if (true) {} });

          Examples of correct code for this rule with the "as-needed" option:

          /*eslint arrow-parens: ["error", "as-needed"]*/
          /*eslint-env es6*/
          
          () => {};
          a => {};
          a => a;
          a => {'\n'};
          a.then(foo => {});
          a.then(foo => { if (true) {} });
          (a, b, c) => a;
          (a = 10) => a;
          ([a, b]) => a;
          ({a, b}) => a;

          requireForBlockBody

          Examples of incorrect code for the { "requireForBlockBody": true } option:

          /*eslint arrow-parens: [2, "as-needed", { "requireForBlockBody": true }]*/
          /*eslint-env es6*/
          
          (a) => a;
          a => {};
          a => {'\n'};
          a.map((x) => x * x);
          a.map(x => {
            return x * x;
          });
          a.then(foo => {});

          Examples of correct code for the { "requireForBlockBody": true } option:

          /*eslint arrow-parens: [2, "as-needed", { "requireForBlockBody": true }]*/
          /*eslint-env es6*/
          
          (a) => {};
          (a) => {'\n'};
          a => ({});
          () => {};
          a => a;
          a.then((foo) => {});
          a.then((foo) => { if (true) {} });
          a((foo) => { if (true) {} });
          (a, b, c) => a;
          (a = 10) => a;
          ([a, b]) => a;
          ({a, b}) => a;

          Further Reading

          Unnecessary escape character: \/.
          Open

              const modulePattern = /^([^\/]*)\/?([^\/]*)/;
          Severity: Minor
          Found in src/require/createResolveRequest.js by eslint

          Disallow unnecessary escape usage (no-useless-escape)

          Escaping non-special characters in strings, template literals, and regular expressions doesn't have any effect, as demonstrated in the following example:

          let foo = "hol\a"; // > foo = "hola"
          let bar = `${foo}\!`; // > bar = "hola!"
          let baz = /\:/ // same functionality with /:/

          Rule Details

          This rule flags escapes that can be safely removed without changing behavior.

          Examples of incorrect code for this rule:

          /*eslint no-useless-escape: "error"*/
          
          "\'";
          '\"';
          "\#";
          "\e";
          `\"`;
          `\"${foo}\"`;
          `\#{foo}`;
          /\!/;
          /\@/;

          Examples of correct code for this rule:

          /*eslint no-useless-escape: "error"*/
          
          "\"";
          '\'';
          "\x12";
          "\u00a9";
          "\371";
          "xs\u2111";
          `\``;
          `\${${foo}\}`;
          `$\{${foo}\}`;
          /\\/g;
          /\t/g;
          /\w\$\*\^\./;

          When Not To Use It

          If you don't want to be notified about unnecessary escapes, you can safely disable this rule. Source: http://eslint.org/docs/rules/

          Unnecessary escape character: \/.
          Open

              const modulePattern = /^([^\/]*)\/?([^\/]*)/;
          Severity: Minor
          Found in src/require/createResolveRequest.js by eslint

          Disallow unnecessary escape usage (no-useless-escape)

          Escaping non-special characters in strings, template literals, and regular expressions doesn't have any effect, as demonstrated in the following example:

          let foo = "hol\a"; // > foo = "hola"
          let bar = `${foo}\!`; // > bar = "hola!"
          let baz = /\:/ // same functionality with /:/

          Rule Details

          This rule flags escapes that can be safely removed without changing behavior.

          Examples of incorrect code for this rule:

          /*eslint no-useless-escape: "error"*/
          
          "\'";
          '\"';
          "\#";
          "\e";
          `\"`;
          `\"${foo}\"`;
          `\#{foo}`;
          /\!/;
          /\@/;

          Examples of correct code for this rule:

          /*eslint no-useless-escape: "error"*/
          
          "\"";
          '\'';
          "\x12";
          "\u00a9";
          "\371";
          "xs\u2111";
          `\``;
          `\${${foo}\}`;
          `$\{${foo}\}`;
          /\\/g;
          /\t/g;
          /\w\$\*\^\./;

          When Not To Use It

          If you don't want to be notified about unnecessary escapes, you can safely disable this rule. Source: http://eslint.org/docs/rules/

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  const module = matches[1].charAt(0) === '@' ?
                      `${matches[1]}/${matches[2]}` :
                      matches[1];
          Severity: Minor
          Found in src/require/createResolveRequest.js and 1 other location - About 40 mins to fix
          src/require/createResolveRequest.js on lines 208..210

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              matches[1].charAt(0) === '@' ?
                                  `${matches[1]}/${matches[2]}` :
                                  matches[1]
          Severity: Minor
          Found in src/require/createResolveRequest.js and 1 other location - About 40 mins to fix
          src/require/createResolveRequest.js on lines 54..56

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status