Sign upLogin

rofrischmann/elodin

View on GitHub
Star
core/parser/src/__tests__/Parser-test.js

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('should correctly parse styles', () => {
    const file = `
style Button {
  backgroundColor: red
  borderColor: rgb(255 255 255)
Severity: Major
Found in core/parser/src/__tests__/Parser-test.js and 4 other locations - About 2 hrs to fix
core/parser/src/__tests__/Parser-test.js on lines 21..36
core/parser/src/__tests__/Parser-test.js on lines 38..57
core/parser/src/__tests__/Parser-test.js on lines 59..83
core/parser/src/__tests__/Parser-test.js on lines 85..104

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('should correctly parse comments', () => {
    const file = `
    # variant comment
    variant Foo {
      Bar
Severity: Major
Found in core/parser/src/__tests__/Parser-test.js and 4 other locations - About 2 hrs to fix
core/parser/src/__tests__/Parser-test.js on lines 4..19
core/parser/src/__tests__/Parser-test.js on lines 21..36
core/parser/src/__tests__/Parser-test.js on lines 38..57
core/parser/src/__tests__/Parser-test.js on lines 85..104

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('should correctly parse multiple styles', () => {
    const file = `
style Button {
  backgroundColor: red
  paddingLeft: 10
Severity: Major
Found in core/parser/src/__tests__/Parser-test.js and 4 other locations - About 2 hrs to fix
core/parser/src/__tests__/Parser-test.js on lines 4..19
core/parser/src/__tests__/Parser-test.js on lines 38..57
core/parser/src/__tests__/Parser-test.js on lines 59..83
core/parser/src/__tests__/Parser-test.js on lines 85..104

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('should correctly parse env condition', () => {
    const file = `
style Button {
  [@hover] {
    backgroundColor: red
Severity: Major
Found in core/parser/src/__tests__/Parser-test.js and 4 other locations - About 2 hrs to fix
core/parser/src/__tests__/Parser-test.js on lines 4..19
core/parser/src/__tests__/Parser-test.js on lines 21..36
core/parser/src/__tests__/Parser-test.js on lines 38..57
core/parser/src/__tests__/Parser-test.js on lines 59..83

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('should correctly parse conditionals', () => {
    const file = `
    variant Mode {
      Dark
      Light
Severity: Major
Found in core/parser/src/__tests__/Parser-test.js and 4 other locations - About 2 hrs to fix
core/parser/src/__tests__/Parser-test.js on lines 4..19
core/parser/src/__tests__/Parser-test.js on lines 21..36
core/parser/src/__tests__/Parser-test.js on lines 59..83
core/parser/src/__tests__/Parser-test.js on lines 85..104

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status