Sign upLogin

ronin-rb/ronin-db-activerecord

View on GitHub
Star

Showing 5 of 11 total issues

Consider simplifying this complex logical expression.
Open

        unless (mac_address || ip_address || host_name || port || service || open_port || cert || url || user_name || email_address || password || credential || advisory || phone_number || street_address || person || organization)
          errors.add(:base, 'note must be associated with a MACAddress, IPAddress, HostName, Port, Service, OpenPort, Cert, URL, UserName, EmailAddress, Password, Credential, Advisory, PhoneNumber, StreetAddress, Person, or Organization')
        end
Severity: Critical
Found in lib/ronin/db/note.rb - About 4 hrs to fix

    Class Cert has 24 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Cert < ActiveRecord::Base

      include Model
      include Model::Importable
    Severity: Minor
    Found in lib/ronin/db/cert.rb - About 2 hrs to fix

      Method import has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def self.import(cert)
        case (public_key = cert.public_key)
        when OpenSSL::PKey::RSA
          public_key_algorithm = :rsa
          public_key_size      = public_key.n.num_bits
      Severity: Minor
      Found in lib/ronin/db/cert.rb - About 1 hr to fix

        Method import has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def self.import(uri)
        uri = URI(uri)

        # find or create the URL scheme, host_name and port
        scheme    = URLScheme.find_or_create_by(name: uri.scheme)
        Severity: Minor
        Found in lib/ronin/db/url.rb - About 1 hr to fix

          Method import has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def self.import(cert)
        case (public_key = cert.public_key)
        when OpenSSL::PKey::RSA
          public_key_algorithm = :rsa
          public_key_size      = public_key.n.num_bits
          Severity: Minor
          Found in lib/ronin/db/cert.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language