Sign upLogin

ronin-rb/ronin-support-web

View on GitHub
Star

Showing 5 of 27 total issues

Class Agent has 40 methods (exceeds 20 allowed). Consider refactoring.
Open

      class Agent

        #
        # Base-class for all {Agent} exceptions.
        #
Severity: Minor
Found in lib/ronin/support/web/agent.rb - About 5 hrs to fix

    File agent.rb has 357 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'ronin/support/network/http'

require 'addressable/uri'
require 'nokogiri'
require 'json'
    Severity: Minor
    Found in lib/ronin/support/web/agent.rb - About 4 hrs to fix

      Method get has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

              def get(url, follow_redirects: @follow_redirects,
                     max_redirects:    @max_redirects,
                     **kwargs)
          response = http_get(url,**kwargs)
      Severity: Minor
      Found in lib/ronin/support/web/agent.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method ws_connect_and_send has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

                def ws_connect_and_send(data,host,port=80, type: :text, ssl: {}, **kwargs,&block)
      Severity: Minor
      Found in lib/ronin/support/web/websocket/mixin.rb - About 35 mins to fix

        Method wss_connect_and_send has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                  def wss_connect_and_send(data,host,port=443, type: :text, ssl: {}, **kwargs,&block)
        Severity: Minor
        Found in lib/ronin/support/web/websocket/mixin.rb - About 35 mins to fix
          Severity
          Category
          Status
          Source
          Language