Sign upLogin

ronzalo/spree_sales

View on GitHub
Star

Showing 2 of 2 total issues

Method validate_value has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def validate_value value, params
      variant = Spree::Variant.where(id: params['variant']).first
      return false unless variant

      valid_sale = true
Severity: Minor
Found in app/models/spree/sale_price.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method put_on_sale has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def put_on_sale value, params={}
    if !params[:currency] || (params[:currency] == "all_currencies") || (params[:currency] == :all_currencies)
      run_on_prices(true) {|p| p.put_on_sale value, params }
    elsif params[:currency]
      prices.find_by(currency: params[:currency]).put_on_sale(value, params) if prices.exists?(currency: params[:currency])
Severity: Minor
Found in app/models/spree/variant_decorator.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language