Sign upLogin

rootslab/syllabus

View on GitHub
Star
lib/commands/server.js

Summary

Maintainability
F
4 days
Test Coverage

Function commands has a Cognitive Complexity of 86 (exceeds 5 allowed). Consider refactoring.
Open

exports.commands = function ( encode, error ) {
    var Abaco = require( 'abaco' )
        , parseIntArray = Abaco.parseIntArray
        , Bolgia = require( 'bolgia' )
        , doString = Bolgia.doString
Severity: Minor
Found in lib/commands/server.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function commands has 298 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.commands = function ( encode, error ) {
    var Abaco = require( 'abaco' )
        , parseIntArray = Abaco.parseIntArray
        , Bolgia = require( 'bolgia' )
        , doString = Bolgia.doString
Severity: Major
Found in lib/commands/server.js - About 1 day to fix

    File server.js has 300 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * SERVER mix-ins.
 */

exports.commands = function ( encode, error ) {
    Severity: Minor
    Found in lib/commands/server.js - About 3 hrs to fix

      Function parseRedisInfo has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              , parseRedisInfo = function ( data ) {
            var str = String( data )
                // skip first 2 bytes : '# '
                , sections = str.slice( 2, str.length ).split( '\r\n# ' )
                , slen = sections.length
      Severity: Minor
      Found in lib/commands/server.js - About 1 hr to fix

        Function parseClientList has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                , parseClientList =  function ( data ) {
            var rows = String( data ).split( '\n' )
                , i = 0
                , row = rows[ 0 ]
                , rlen = rows.length
        Severity: Minor
        Found in lib/commands/server.js - About 1 hr to fix

          Function parseRoleReply has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  , parseRoleReply = function ( arr ) {
            var a = isArray( arr ) ? arr : []
                , alen = a.length
                , type = null
                ;
          Severity: Minor
          Found in lib/commands/server.js - About 1 hr to fix

            Function parseConfigGet has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    , parseConfigGet = function ( arr ) {
            var a = isArray( arr ) ? arr : []
                , alen = a.length
                , i = 0
                , k = null
            Severity: Minor
            Found in lib/commands/server.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      , flushall : function ( async, cback ) {
            if ( typeof async === 'function' ) return encode( 'FLUSHALL', null, async );
            else if ( async === true ) return encode( 'FLUSHALL', 'ASYNC', null, cback );
            return encode( 'FLUSHALL', null, cback );
        }
              Severity: Major
              Found in lib/commands/server.js and 1 other location - About 1 hr to fix
              lib/commands/server.js on lines 313..317

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      , flushdb : function ( async, cback ) {
            if ( typeof async === 'function' ) return encode( 'FLUSHDB', null, async );
            else if ( async === true ) return encode( 'FLUSHDB', 'ASYNC', null, cback );
            return encode( 'FLUSHDB', null, cback );
        }
              Severity: Major
              Found in lib/commands/server.js and 1 other location - About 1 hr to fix
              lib/commands/server.js on lines 307..311

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status