rootslab/vapid

View on GitHub

Showing 32 of 66 total issues

Function parse has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    bproto.parse = function ( data, pos ) {
        var me = this
            , dlen = data.length
            , p = pos || 0
            , curry = 0
Severity: Minor
Found in lib/parser/rules/bulk.js - About 1 hr to fix

    Function publish has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            , publish : function ( command, args, sock ) {
                var me = this
                    , clients = me.clients
                    , pubsub = me.pubsub
                    , channels = pubsub.channels
    Severity: Minor
    Found in lib/commands/pubsub.js - About 1 hr to fix

      Function onParserMatch has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                              , onParserMatch = function ( e, d, reveal ) {
                                  var cmd = d[ 0 ].toLowerCase()
                                      , sub = null
                                      , ocmd = me.commands[ cmd ]
                                      , osub = null
      Severity: Minor
      Found in lib/vapid.js - About 1 hr to fix

        Function subscribe has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                , subscribe : function ( command, args, sock ) {
                    var me = this
                        , channels = me.pubsub.channels
                        , schannels = null
                        , alen = args.length
        Severity: Minor
        Found in lib/commands/pubsub.js - About 1 hr to fix

          Function MultiBulkRule has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          exports.MultiBulkRule = ( function () {
              var Rule = require('./rule').Rule
                  , util = require( 'util' )
                  , MultiBulkRule = function ( char ) {
                      var me = this
          Severity: Minor
          Found in lib/parser/rules/mbulk.js - About 1 hr to fix

            Function collectResult has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    , collectResult = function ( rule, error, data ) {
                        var me = this
                            , arr = null
                            , peela = me.peela
                            , head = peela.head()
            Severity: Minor
            Found in lib/parser/vapid_parser.js - About 1 hr to fix

              Function Rule has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

              exports.Rule = ( function () {
                  var emitter = require('events').EventEmitter
                      , util = require( 'util' )
                      , Abaco = require( 'abaco' )
                      , max = Math.max
              Severity: Minor
              Found in lib/parser/rules/rule.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function commands has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              exports.commands = function () {
              
                  var wmsg = function ( cmd ) {
                          return '-ERR wrong number of arguments for \'' + cmd + '\' command\r\n';
                      }
              Severity: Minor
              Found in lib/commands/server.js - About 1 hr to fix

                Function crash has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    mproto.crash = function () {
                        var me = this
                            , clients = me.clients
                            , cqueues = me.cqueues
                            , parsers = me.parsers
                Severity: Minor
                Found in lib/vapid.js - About 1 hr to fix

                  Function MultiBulkRule has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                  exports.MultiBulkRule = ( function () {
                      var Rule = require('./rule').Rule
                          , util = require( 'util' )
                          , MultiBulkRule = function ( char ) {
                              var me = this
                  Severity: Minor
                  Found in lib/parser/rules/mbulk.js - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid too many return statements within this function.
                  Open

                          return [ me, false, d, m, data ];
                  Severity: Major
                  Found in lib/parser/rules/bulk.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return [ me, false, d, v + 2, data ];
                    Severity: Major
                    Found in lib/parser/rules/bulk.js - About 30 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language