Sign upLogin

rootslab/vapid

View on GitHub
Star
lib/vapid.js

Summary

Maintainability
F
6 days
Test Coverage

Function Vapid has a Cognitive Complexity of 136 (exceeds 5 allowed). Consider refactoring.
Open

exports.Vapid = ( function () {
    var log = console.log
        , net = require( 'net' )
        , util = require( 'util' )
        , Bolgia = require( 'bolgia' )
Severity: Minor
Found in lib/vapid.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Vapid has 301 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.Vapid = ( function () {
    var log = console.log
        , net = require( 'net' )
        , util = require( 'util' )
        , Bolgia = require( 'bolgia' )
Severity: Major
Found in lib/vapid.js - About 1 day to fix

    Function Vapid has 99 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            , Vapid = function ( opt ) {
            var me = this
                , is = me instanceof Vapid
                ;
            if ( ! is ) return new Vapid( opt );
    Severity: Major
    Found in lib/vapid.js - About 3 hrs to fix

      File vapid.js has 303 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*
 * Vapid, a vacuous Redis implementation for connection tests,
 * with a fully functional PubSub system for multiple clients.
 *
 * Copyright(c) 2014 Guglielmo Ferri <44gatti@gmail.com>
      Severity: Minor
      Found in lib/vapid.js - About 3 hrs to fix

        Function onConnection has 77 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                        , onConnection = function ( sock ) {
                    var me = this
                        , clients = me.clients
                        , cqueues = me.cqueues
                        , parsers = me.parsers
        Severity: Major
        Found in lib/vapid.js - About 3 hrs to fix

          Function resetSubscriptions has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  , resetSubscriptions = function ( sock, pubsub ) {
            var pchannels = pubsub.channels
                , ppatterns = pubsub.patterns
                , schannels = sock.pubsub.channels
                , spatterns = sock.pubsub.patterns
          Severity: Minor
          Found in lib/vapid.js - About 1 hr to fix

            Function onParserMatch has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                                    , onParserMatch = function ( e, d, reveal ) {
                            var cmd = d[ 0 ].toLowerCase()
                                , sub = null
                                , ocmd = me.commands[ cmd ]
                                , osub = null
            Severity: Minor
            Found in lib/vapid.js - About 1 hr to fix

              Function crash has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  mproto.crash = function () {
        var me = this
            , clients = me.clients
            , cqueues = me.cqueues
            , parsers = me.parsers
              Severity: Minor
              Found in lib/vapid.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            for ( s = 0; s < splen; ++s ) {
                pname = spatterns[ s ];
                pattern = ppatterns[ pname ];
                // check if pattern exists
                if ( ! pattern ) continue;
                Severity: Major
                Found in lib/vapid.js and 1 other location - About 3 hrs to fix
                lib/vapid.js on lines 85..98

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 109.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            for ( ; s < sclen; ++s ) {
                cname = schannels[ s ];
                channel = pchannels[ cname ];
                // check if channel exists
                if ( ! channel ) continue;
                Severity: Major
                Found in lib/vapid.js and 1 other location - About 3 hrs to fix
                lib/vapid.js on lines 99..112

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 109.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status