Sign upLogin

rsercano/mongoclient

View on GitHub
Star
client/imports/ui/collection/add.js

Summary

Maintainability
F
3 days
Test Coverage

File add.js has 262 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { SessionManager, UIComponents, Enums, ExtendedJSON, ErrorHandler, Notification } from '/client/imports/modules';
import { Communicator, ReactivityProvider } from '/client/imports/facades';
import { Connection } from '/client/imports/ui';
import $ from 'jquery';
Severity: Minor
Found in client/imports/ui/collection/add.js - About 2 hrs to fix

    Function gatherOptions has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      gatherOptions() {
    const options = this.getOptions();
    if (options.ERROR) {
      Notification.error(options.ERROR);
      return;
    Severity: Minor
    Found in client/imports/ui/collection/add.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function gatherOptions has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      gatherOptions() {
    const options = this.getOptions();
    if (options.ERROR) {
      Notification.error(options.ERROR);
      return;
    Severity: Minor
    Found in client/imports/ui/collection/add.js - About 1 hr to fix

      Function prepareShowForm has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        prepareShowForm(col) {
    if (!col) return;

    const cmbCollectionOrView = $('#cmbCollectionOrView');
    const modalTitle = $('#collectionAddModalTitle');
      Severity: Minor
      Found in client/imports/ui/collection/add.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getOptions has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        getOptions() {
    const result = {};
    const collectionAddOptions = SessionManager.get(SessionManager.strSessionSelectedAddCollectionOptions);

    if ($.inArray('CAPPED', collectionAddOptions) !== -1) {
      Severity: Minor
      Found in client/imports/ui/collection/add.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function initializeForm has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        initializeForm(collection) {
    if (!collection) {
      Notification.warning('collection-not-found', null, { name: collection });
      $('#collectionAddModal').modal('hide');
      return;
      Severity: Minor
      Found in client/imports/ui/collection/add.js - About 1 hr to fix

        Function setOptionsForCollection has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          setOptionsForCollection(col) {
    if (!col || !col.options) return;

    const optionsToSelect = [];
    if (col.options.capped) optionsToSelect.push('CAPPED');
        Severity: Minor
        Found in client/imports/ui/collection/add.js - About 1 hr to fix

          Function initializeForm has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            initializeForm(collection) {
    if (!collection) {
      Notification.warning('collection-not-found', null, { name: collection });
      $('#collectionAddModal').modal('hide');
      return;
          Severity: Minor
          Found in client/imports/ui/collection/add.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function setStorageEngineAndValidator has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            setStorageEngineAndValidator(col) {
    if (!col || !col.options) return;

    if (col.options.storageEngine) {
      UIComponents.Editor.setCodeMirrorValue($('#divStorageEngine'), JSON.stringify(col.options.storageEngine), $('#txtStorageEngine'));
          Severity: Minor
          Found in client/imports/ui/collection/add.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function addCollection has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            addCollection() {
    const name = $('#inputCollectionViewName').val();
    if (!name) {
      Notification.warning('name-required');
      return;
          Severity: Minor
          Found in client/imports/ui/collection/add.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                  return;
          Severity: Major
          Found in client/imports/ui/collection/add.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return;
            Severity: Major
            Found in client/imports/ui/collection/add.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return options;
              Severity: Major
              Found in client/imports/ui/collection/add.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return options;
                Severity: Major
                Found in client/imports/ui/collection/add.js - About 30 mins to fix

                  Function getFlagValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    getFlagValue() {
    const twoSizesIndexes = UIComponents.Checkbox.getState($('#inputTwoSizesIndexes'));
    const noPadding = UIComponents.Checkbox.getState($('#inputNoPadding'));
    if (!twoSizesIndexes && !noPadding) return 0;
    if (twoSizesIndexes && !noPadding) return 1;
                  Severity: Minor
                  Found in client/imports/ui/collection/add.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                      if (validatorVal) {
      options.validator = ExtendedJSON.convertAndCheckJSON(validatorVal);
      if (options.validator.ERROR) {
        Notification.error('syntax-error-validator', null, { error: options.validator.ERROR });
        return;
                  Severity: Major
                  Found in client/imports/ui/collection/add.js and 2 other locations - About 1 hr to fix
                  client/imports/ui/collection/add.js on lines 71..77
                  client/imports/ui/collection/add.js on lines 96..102

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 69.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                      if (storageEnginveVal) {
      options.storageEngine = ExtendedJSON.convertAndCheckJSON(storageEnginveVal);
      if (options.storageEngine.ERROR) {
        Notification.error('syntax-error-storage-engine', null, { error: options.storageEngine.ERROR });
        return;
                  Severity: Major
                  Found in client/imports/ui/collection/add.js and 2 other locations - About 1 hr to fix
                  client/imports/ui/collection/add.js on lines 71..77
                  client/imports/ui/collection/add.js on lines 107..113

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 69.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                      if (collationVal) {
      options.collation = ExtendedJSON.convertAndCheckJSON(collationVal);
      if (options.collation.ERROR) {
        Notification.error('syntax-error-collation', null, { error: options.collation.ERROR });
        return;
                  Severity: Major
                  Found in client/imports/ui/collection/add.js and 2 other locations - About 1 hr to fix
                  client/imports/ui/collection/add.js on lines 96..102
                  client/imports/ui/collection/add.js on lines 107..113

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 69.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        if (col.options.validator) {
        UIComponents.Editor.setCodeMirrorValue($('#divValidatorAddCollection'), JSON.stringify(col.options.validator), $('#txtValidatorAddCollection'));
      }
                  Severity: Major
                  Found in client/imports/ui/collection/add.js and 1 other location - About 1 hr to fix
                  client/imports/ui/collection/add.js on lines 138..140

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if (col.options.storageEngine) {
      UIComponents.Editor.setCodeMirrorValue($('#divStorageEngine'), JSON.stringify(col.options.storageEngine), $('#txtStorageEngine'));
    }
                  Severity: Major
                  Found in client/imports/ui/collection/add.js and 1 other location - About 1 hr to fix
                  client/imports/ui/collection/add.js on lines 142..144

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        if (optionsToSelect.indexOf('CAPPED') !== -1) {
        $('#inputCappedCollectionMaxDocs').val(col.options.max);
        $('#inputCappedCollectionSize').val(col.options.size);
      }
                  Severity: Minor
                  Found in client/imports/ui/collection/add.js and 1 other location - About 45 mins to fix
                  client/imports/ui/connection/helper.js on lines 71..82

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 12 locations. Consider refactoring.
                  Open

                      const connection = ReactivityProvider.findOne(ReactivityProvider.types.Connections, { _id: SessionManager.get(SessionManager.strSessionConnection)._id });
                  Severity: Major
                  Found in client/imports/ui/collection/add.js and 11 other locations - About 35 mins to fix
                  client/imports/ui/backup/index.js on lines 204..204
                  client/imports/ui/collection/update_view_pipeline.js on lines 36..36
                  client/imports/ui/collection/validation_rules.js on lines 25..25
                  client/imports/ui/connection/helper.js on lines 117..117
                  client/imports/ui/connection/index.js on lines 128..128
                  client/imports/ui/user_management/roles.js on lines 217..217
                  client/imports/ui/user_management/tree.js on lines 116..116
                  client/imports/ui/user_management/users.js on lines 132..132
                  client/imports/ui/user_management/users.js on lines 226..226
                  client/imports/views/layouts/navigation/navigation.js on lines 28..28
                  client/imports/views/layouts/navigation/navigation.js on lines 110..110

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status