Sign upLogin

rsercano/mongoclient

View on GitHub
Star
client/imports/ui/file_management/index.js

Summary

Maintainability
C
1 day
Test Coverage

Function initFilesInformation has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  initFilesInformation() {
    Notification.start('#btnReloadFiles');

    let selector = UIComponents.Editor.getCodeMirrorValue($('#divSelector'));
    selector = ExtendedJSON.convertAndCheckJSON(selector);
Severity: Minor
Found in client/imports/ui/file_management/index.js - About 2 hrs to fix

    Function callback has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          callback: (err, result) => {
        if (err || result.error) {
          ErrorHandler.showMeteorFuncError(err, result);
          return;
        }
    Severity: Minor
    Found in client/imports/ui/file_management/index.js - About 1 hr to fix

      Function deleteFiles has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        deleteFiles() {
    Notification.modal({
      title: 'are-you-sure',
      text: 'all-selected-files-will-be-wiped',
      type: 'warning',
      Severity: Minor
      Found in client/imports/ui/file_management/index.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function updateMetadata has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        updateMetadata() {
    Notification.modal({
      title: 'are-you-sure',
      text: 'existing-metadata-will-be-overriden',
      type: 'warning',
      Severity: Minor
      Found in client/imports/ui/file_management/index.js - About 1 hr to fix

        Function delete has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          delete() {
    const fileRow = SessionManager.get(SessionManager.strSessionSelectedFile);
    if (fileRow) {
      Notification.modal({
        title: 'are-you-sure',
        Severity: Minor
        Found in client/imports/ui/file_management/index.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function deleteFiles has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          deleteFiles() {
    Notification.modal({
      title: 'are-you-sure',
      text: 'all-selected-files-will-be-wiped',
      type: 'warning',
        Severity: Minor
        Found in client/imports/ui/file_management/index.js - About 1 hr to fix

          Function updateMetadata has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            updateMetadata() {
    Notification.modal({
      title: 'are-you-sure',
      text: 'existing-metadata-will-be-overriden',
      type: 'warning',
          Severity: Minor
          Found in client/imports/ui/file_management/index.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    columnDefs: [
            {
              targets: [5],
              data: null,
              width: '5%',
          Severity: Major
          Found in client/imports/ui/file_management/index.js and 1 other location - About 2 hrs to fix
          client/imports/ui/user_management/users.js on lines 289..308

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 78.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      callback: (err, result) => {
              if (err || result.err) ErrorHandler.showMeteorFuncError(err, result);
              else {
                Notification.success('deleted-successfully');
                this.initFilesInformation();
          Severity: Major
          Found in client/imports/ui/file_management/index.js and 1 other location - About 1 hr to fix
          client/imports/ui/stored_functions/index.js on lines 128..134

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status