rsercano/mongoclient

View on GitHub
client/imports/ui/querying/save_editor.js

Summary

Maintainability
C
1 day
Test Coverage

Function saveFindEditor has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  saveFindEditor() {
    const activeTab = $('#resultTabs').find('li.active').find('a').attr('href');
    const findData = $(activeTab).data('findData');
    if (!findData) {
      Notification.error('no-result-found-to-save');
Severity: Minor
Found in client/imports/ui/querying/save_editor.js - About 1 hr to fix

    Function saveFindEditor has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      saveFindEditor() {
        const activeTab = $('#resultTabs').find('li.active').find('a').attr('href');
        const findData = $(activeTab).data('findData');
        if (!findData) {
          Notification.error('no-result-found-to-save');
    Severity: Minor
    Found in client/imports/ui/querying/save_editor.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function deleteDocument has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      deleteDocument() {
        const doc = ExtendedJSON.convertAndCheckJSON(QueryRender.getActiveEditorValue());
        if (doc.ERROR) {
          Notification.error('syntax-error-editor', null, { error: doc.ERROR });
          return;
    Severity: Minor
    Found in client/imports/ui/querying/save_editor.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function saveEditor has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      saveEditor() {
        const doc = ExtendedJSON.convertAndCheckJSON(QueryRender.getActiveEditorValue());
        if (doc.ERROR) {
          Notification.error('syntax-error-editor', null, { error: doc.ERROR });
          return;
    Severity: Minor
    Found in client/imports/ui/querying/save_editor.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function deleteDocument has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      deleteDocument() {
        const doc = ExtendedJSON.convertAndCheckJSON(QueryRender.getActiveEditorValue());
        if (doc.ERROR) {
          Notification.error('syntax-error-editor', null, { error: doc.ERROR });
          return;
    Severity: Minor
    Found in client/imports/ui/querying/save_editor.js - About 1 hr to fix

      Function saveEditor has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        saveEditor() {
          const doc = ExtendedJSON.convertAndCheckJSON(QueryRender.getActiveEditorValue());
          if (doc.ERROR) {
            Notification.error('syntax-error-editor', null, { error: doc.ERROR });
            return;
      Severity: Minor
      Found in client/imports/ui/querying/save_editor.js - About 1 hr to fix

        Function getChangedObjects has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          getChangedObjects(findData, activeEditorValue, deletedObjectIds, updateObjects, addedObjects) {
        Severity: Minor
        Found in client/imports/ui/querying/save_editor.js - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status