Sign upLogin

rsercano/mongoclient

View on GitHub
Star
client/imports/ui/user_management/tree.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function initUserTree has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  initUserTree() {
    this.defaultInformationText = Helper.translate({ key: 'user_management_default_tree_text' });
    SessionManager.set(SessionManager.strSessionUsermanagementInfo, '');
    SessionManager.set(SessionManager.strSessionSelectionUserManagement, this.defaultInformationText);
    $('#btnEditUser').hide();
Severity: Minor
Found in client/imports/ui/user_management/tree.js - About 1 hr to fix

    Function fillInformation has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    const fillInformation = function (node) {
  if (!node.data || !node.data[0]) return;

  if (node.data[0].user) {
    SessionManager.set(SessionManager.strSessionUsermanagementManageSelection, node.text);
    Severity: Minor
    Found in client/imports/ui/user_management/tree.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return type;
    Severity: Major
    Found in client/imports/ui/user_management/tree.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          if (type === 'non-system') return 'all non-system collections';
      Severity: Major
      Found in client/imports/ui/user_management/tree.js - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            result.push(createEmptyChildrenNode({ text: Helper.translate({ key: 'privileges' }), isBuiltin: role.isBuiltin, icon: 'fa fa-list-ul' }));
        Severity: Minor
        Found in client/imports/ui/user_management/tree.js and 1 other location - About 40 mins to fix
        client/imports/ui/user_management/tree.js on lines 203..203

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            result.push(createEmptyChildrenNode({ text: Helper.translate({ key: 'inherited_privileges' }), isBuiltin: role.isBuiltin, icon: 'fa fa-list-ul' }));
        Severity: Minor
        Found in client/imports/ui/user_management/tree.js and 1 other location - About 40 mins to fix
        client/imports/ui/user_management/tree.js on lines 202..202

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 12 locations. Consider refactoring.
        Open

            const connection = ReactivityProvider.findOne(ReactivityProvider.types.Connections, { _id: SessionManager.get(SessionManager.strSessionConnection)._id });
        Severity: Major
        Found in client/imports/ui/user_management/tree.js and 11 other locations - About 35 mins to fix
        client/imports/ui/backup/index.js on lines 204..204
        client/imports/ui/collection/add.js on lines 277..277
        client/imports/ui/collection/update_view_pipeline.js on lines 36..36
        client/imports/ui/collection/validation_rules.js on lines 25..25
        client/imports/ui/connection/helper.js on lines 117..117
        client/imports/ui/connection/index.js on lines 128..128
        client/imports/ui/user_management/roles.js on lines 217..217
        client/imports/ui/user_management/users.js on lines 132..132
        client/imports/ui/user_management/users.js on lines 226..226
        client/imports/views/layouts/navigation/navigation.js on lines 28..28
        client/imports/views/layouts/navigation/navigation.js on lines 110..110

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status