Sign upLogin

rsercano/mongoclient

View on GitHub
Star
server/imports/core/mongodb/helper.js

Summary

Maintainability
C
1 day
Test Coverage

Function getProperBinary has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  getProperBinary(binaryName) {
    const settings = Database.readOne({ type: Database.types.Settings, query: {} });
    const errorMessage = `binary-${binaryName}-not-found`;
    if (settings.mongoBinaryPath) {
      const dir = `${settings.mongoBinaryPath.replace(/\\/g, '/')}/`;
Severity: Minor
Found in server/imports/core/mongodb/helper.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getProperBinary has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  getProperBinary(binaryName) {
    const settings = Database.readOne({ type: Database.types.Settings, query: {} });
    const errorMessage = `binary-${binaryName}-not-found`;
    if (settings.mongoBinaryPath) {
      const dir = `${settings.mongoBinaryPath.replace(/\\/g, '/')}/`;
Severity: Minor
Found in server/imports/core/mongodb/helper.js - About 1 hr to fix

    Function proceedMapReduceExecution has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      proceedMapReduceExecution({ execution, map, reduce, options, metadataToLog }) {
    options = EJSON.deserialize(options);

    const result = Async.runSync((done) => {
      try {
    Severity: Minor
    Found in server/imports/core/mongodb/helper.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function proceedExecutionStepByStep has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      proceedExecutionStepByStep(entry, last, done, execution, metadataToLog) {
    Severity: Minor
    Found in server/imports/core/mongodb/helper.js - About 35 mins to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              entry[key].push((err, docs) => {
          let errorToBeThrown = null;
          if (err) errorToBeThrown = Error.createWithoutThrow({ type: Error.types.QueryError, externalError: err, metadataToLog });
          done(errorToBeThrown, docs);
        });
      Severity: Major
      Found in server/imports/core/mongodb/helper.js and 3 other locations - About 1 hr to fix
      server/imports/core/mongodb/gridfs.js on lines 114..118
      server/imports/core/mongodb/helper.js on lines 78..82
      server/imports/core/mongodb/index.js on lines 33..37

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                  resultCollection.find().toArray((err, finalResult) => {
              let errorToBeThrown = null;
              if (err) errorToBeThrown = Error.createWithoutThrow({ type: Error.types.QueryError, externalError: err, metadataToLog });
              done(errorToBeThrown, finalResult);
            });
      Severity: Major
      Found in server/imports/core/mongodb/helper.js and 3 other locations - About 1 hr to fix
      server/imports/core/mongodb/gridfs.js on lines 114..118
      server/imports/core/mongodb/helper.js on lines 16..20
      server/imports/core/mongodb/index.js on lines 33..37

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            try {
        for (let i = 0; i < methodArray.length; i += 1) {
          const last = (i === (methodArray.length - 1));
          const entry = EJSON.deserialize(methodArray[i]);
      Severity: Minor
      Found in server/imports/core/mongodb/helper.js and 2 other locations - About 40 mins to fix
      server/imports/core/mongodb/helper.js on lines 71..89
      server/imports/core/mongodb/index.js on lines 155..160

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                if (firstError) {
            done(Error.createWithoutThrow({ type: Error.types.QueryError, externalError: firstError, metadataToLog }), null);
            return;
          }
      Severity: Minor
      Found in server/imports/core/mongodb/helper.js and 1 other location - About 40 mins to fix
      server/imports/core/mongodb/gridfs.js on lines 61..64

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            try {
        execution.mapReduce(map, reduce, options, (firstError, resultCollection) => {
          if (firstError) {
            done(Error.createWithoutThrow({ type: Error.types.QueryError, externalError: firstError, metadataToLog }), null);
            return;
      Severity: Minor
      Found in server/imports/core/mongodb/helper.js and 2 other locations - About 40 mins to fix
      server/imports/core/mongodb/helper.js on lines 98..107
      server/imports/core/mongodb/index.js on lines 155..160

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status