Sign upLogin

rstgroup/json-api-php

View on GitHub
Star

Showing 5 of 5 total issues

Writer has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

class Writer
{
    const AS_ID     = 'id';
    const AS_OBJECT = 'object';
    const AS_OBJECTS_ARRAY  = 'objectsArray';
Severity: Minor
Found in src/RstGroup/JsonApiPhp/Writer.php - About 3 hrs to fix

    File Writer.php has 273 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * @author tbedkowski
 */
    Severity: Minor
    Found in src/RstGroup/JsonApiPhp/Writer.php - About 2 hrs to fix

      Function renderLinks has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function renderLinks(EntityInterface $entity)
    {
        $links = array();
        foreach ($this->relations as $relation) {
            $type = $relation->getCollectionName();
      Severity: Minor
      Found in src/RstGroup/JsonApiPhp/Writer.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method renderLink has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          protected function renderLink($relType, $id, $href, array $binds, $type)
      Severity: Minor
      Found in src/RstGroup/JsonApiPhp/Writer.php - About 35 mins to fix

        Function bind has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function bind(array $binds, $string)
    {
        foreach ($binds as $bind => $value) {
            if ($value === null) {
                continue;
        Severity: Minor
        Found in src/RstGroup/JsonApiPhp/Writer.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language