Showing 9 of 17 total issues
Class MatchPresenter
has 40 methods (exceeds 20 allowed). Consider refactoring. Open
class MatchPresenter < Presenter
expose :to_key, :to_param,
:id,
:number,
Class Bet
has 22 methods (exceeds 20 allowed). Consider refactoring. Open
class Bet < ActiveRecord::Base
belongs_to :user
has_one :payment, dependent: :destroy
has_many :match_bets, dependent: :destroy
Method answer_must_match_answer_type
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
def answer_must_match_answer_type
if !self.answer.blank? && !self.answer_type.blank?
case self.answer_type
when 'team'
errors.add(:answer, :invalid) unless (Team.count > 0 && Team.where(id: Integer(self.answer)).count == 1)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method result
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def result
return unless valid?
if goals_a == goals_b
if penalty_winner_id.present?
penalty_winner_id == match.team_a.id ? :team_a : :team_b
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method result
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def result
return unless valid? && scorable?
if goals_a == goals_b
if drawable?
:draw
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method no_draw_after_group_phase
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def no_draw_after_group_phase
return unless with_known_teams? && with_known_goals? && !drawable?
if goals_draw?
if !with_known_penalty_goals?
errors.add(:penalty_goals_a, :blank)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method scorable?
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def scorable?
return false unless locked?
return false unless with_known_teams?
return false unless with_known_goals?
return false if goals_draw? && !drawable? && !with_known_penalty_goals?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update!
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def update!
set_payment_attributes_from_transaction
if valid_status_change?
payment.save!
if status_changed?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method set_payment_attributes_from_transaction
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def set_payment_attributes_from_transaction
payment.transaction_code = transaction_code_from_transaction if payment.transaction_code.blank?
payment.status = status_from_transaction
@next_payment_status = payment.status
unless (@next_payment_status.initiated? || @next_payment_status.waiting_payment? || @next_payment_status.in_analysis?)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"