Showing 181 of 329 total issues
Avoid deeply nested control flow statements. Open
Open
if (busy == 0 && casBusy()) {
boolean created = false;
try { // Recheck under lock
Cell[] rs; int m, j;
if ((rs = cells) != null &&
Avoid deeply nested control flow statements. Open
Open
if ((e.val = v) == null) {
deleted = true;
Node en = e.next;
if (pred != null)
pred.next = en;
Avoid deeply nested control flow statements. Open
Open
if (count >= TREE_THRESHOLD)
replaceWithTreeBin(tab, i, k);
Avoid deeply nested control flow statements. Open
Open
for (Node e = tabAt(tab, i); e != null; e = e.next) {
if (++c > TREE_THRESHOLD &&
(e.key instanceof Comparable)) {
replaceWithTreeBin(tab, i, e.key);
break;
Avoid deeply nested control flow statements. Open
Open
if (count >= TREE_THRESHOLD)
replaceWithTreeBin(tab, i, k);
Avoid deeply nested control flow statements. Open
Open
if ((pr = p.right) != null && h >= pr.hash && (r = getTreeNode(h, k, pr)) != null)
return r;
// try to continue iterating on the left side
else if ((pl = p.left) != null && h <= pl.hash)
dir = -1;
Avoid deeply nested control flow statements. Open
Open
for (Node e = tabAt(tab, i); e != null; e = e.next) {
if (++c > TREE_THRESHOLD &&
(e.key instanceof Comparable)) {
replaceWithTreeBin(tab, i, e.key);
break;
Method writeObject
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
@SuppressWarnings("unchecked") private void writeObject(java.io.ObjectOutputStream s)
throws java.io.IOException {
if (segments == null) { // for serialization compatibility
segments = (Segment<K,V>[])
new Segment<?,?>[DEFAULT_CONCURRENCY_LEVEL];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
Open
if ((pr = p.right) != null && h >= pr.hash && (r = getTreeNode(h, k, pr)) != null)
return r;
else // continue descending down the left subtree
dir = -1;
Avoid deeply nested control flow statements. Open
Open
if (!collide && q != null && q.hash == p.hash)
collide = true;
Avoid deeply nested control flow statements. Open
Open
if (busy == 0 && casBusy()) {
boolean created = false;
try { // Recheck under lock
Cell[] rs; int m, j;
if ((rs = cells) != null &&
Avoid deeply nested control flow statements. Open
Open
if ((pr = p.right) != null && h >= pr.hash && (r = getTreeNode(h, k, pr)) != null)
return r;
else // continue descending down the left subtree
dir = -1;
Method compare_and_set
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
def compare_and_set(old_value, new_value)
return false unless @___mutex.try_lock
begin
return false unless @___value.equal? old_value
@___value = new_value
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
Open
if ((p.val = v) == null) {
deleted = true;
t.deleteTreeNode(p);
}
Avoid deeply nested control flow statements. Open
Open
if (!collide && q != null && q.hash == p.hash)
collide = true;
Avoid deeply nested control flow statements. Open
Open
if ((e.val = v) == null) {
deleted = true;
Node en = e.next;
if (pred != null)
pred.next = en;
Avoid deeply nested control flow statements. Open
Open
if ((pr = p.right) != null && h >= pr.hash && (r = getTreeNode(h, k, pr)) != null)
return r;
// try to continue iterating on the left side
else if ((pl = p.left) != null && h <= pl.hash)
dir = -1;
Avoid deeply nested control flow statements. Open
Open
if (spins -= 1) == 0
Thread.pass # yield before blocking
else
randomizer = base_randomizer = Util::XorShiftRandom.xorshift(base_randomizer) if randomizer.zero?
end
Method split_old_bin
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def split_old_bin(table, new_table, i, node, node_hash, forwarder)
Method attempt_internal_compute_if_absent
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def attempt_internal_compute_if_absent(key, hash, current_table, i, node, node_hash)