Sign upLogin

ruby-grape/grape-swagger-rails

View on GitHub
Star
app/assets/javascripts/grape_swagger_rails/swagger-oauth.js

Summary

Maintainability
F
3 days
Test Coverage

Function handleLogin has 147 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function handleLogin() {
  var scopes = [];

  var auths = window.swaggerUi.api.authSchemes || window.swaggerUi.api.securityDefinitions;
  if(auths) {
Severity: Major
Found in app/assets/javascripts/grape_swagger_rails/swagger-oauth.js - About 5 hrs to fix

    Function handleLogin has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

    function handleLogin() {
  var scopes = [];

  var auths = window.swaggerUi.api.authSchemes || window.swaggerUi.api.securityDefinitions;
  if(auths) {
    Severity: Minor
    Found in app/assets/javascripts/grape_swagger_rails/swagger-oauth.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File swagger-oauth.js has 301 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    var appName;
var popupMask;
var popupDialog;
var clientId;
var realm;
    Severity: Minor
    Found in app/assets/javascripts/grape_swagger_rails/swagger-oauth.js - About 3 hrs to fix

      Function onOAuthComplete has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      window.onOAuthComplete = function onOAuthComplete(token,OAuthSchemeKey) {
  if(token) {
    if(token.error) {
      var checkbox = $('input[type=checkbox],.secured')
      checkbox.each(function(pos){
      Severity: Major
      Found in app/assets/javascripts/grape_swagger_rails/swagger-oauth.js - About 2 hrs to fix

        Function processOAuthCode has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        window.processOAuthCode = function processOAuthCode(data) {
  var OAuthSchemeKey = data.state;

  // redirect_uri is required in auth code flow 
  // see https://tools.ietf.org/html/draft-ietf-oauth-v2-31#section-4.1.3
        Severity: Minor
        Found in app/assets/javascripts/grape_swagger_rails/swagger-oauth.js - About 1 hr to fix

          Function onOAuthComplete has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          window.onOAuthComplete = function onOAuthComplete(token,OAuthSchemeKey) {
  if(token) {
    if(token.error) {
      var checkbox = $('input[type=checkbox],.secured')
      checkbox.each(function(pos){
          Severity: Minor
          Found in app/assets/javascripts/grape_swagger_rails/swagger-oauth.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                      for(var i=0; i < requiredScopes.length; i++) {
              var s = requiredScopes[i];
              if(window.enabledScopes && window.enabledScopes.indexOf(s) == -1) {
                diff.push(s);
              }
          Severity: Major
          Found in app/assets/javascripts/grape_swagger_rails/swagger-oauth.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                      for(i = 0; i < auth.scopes.length; i++) {
            scopes.push(auth.scopes[i]);
          }
            Severity: Major
            Found in app/assets/javascripts/grape_swagger_rails/swagger-oauth.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                          if(o.hasOwnProperty(t) && t === 'implicit') {
              var dets = o[t];
              var ep = dets.loginEndpoint.url;
              url = dets.loginEndpoint.url + '?response_type=token';
              window.swaggerUi.tokenName = dets.tokenName;
              Severity: Major
              Found in app/assets/javascripts/grape_swagger_rails/swagger-oauth.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                          for(scope in auth.scopes) {
            scopes.push({scope: scope, description: auth.scopes[scope], OAuthSchemeKey: key});
          }
                Severity: Major
                Found in app/assets/javascripts/grape_swagger_rails/swagger-oauth.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                if(inner)
                requiredScopes.push(inner);
                  Severity: Major
                  Found in app/assets/javascripts/grape_swagger_rails/swagger-oauth.js - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                if(diff.length > 0){
              o = v.parentNode.parentNode;
              $(o.parentNode).find('.api-ic.ic-on').addClass('ic-off');
              $(o.parentNode).find('.api-ic.ic-on').removeClass('ic-on');
                    Severity: Major
                    Found in app/assets/javascripts/grape_swagger_rails/swagger-oauth.js - About 45 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  else if (o.hasOwnProperty(t) && t === 'accessCode') {
              var dets = o[t];
              var ep = dets.tokenRequestEndpoint.url;
              url = dets.tokenRequestEndpoint.url + '?response_type=code';
              window.swaggerUi.tokenName = dets.tokenName;
                      Severity: Major
                      Found in app/assets/javascripts/grape_swagger_rails/swagger-oauth.js and 1 other location - About 1 hr to fix
                      app/assets/javascripts/grape_swagger_rails/swagger-oauth.js on lines 147..158

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 68.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  if(o.hasOwnProperty(t) && t === 'implicit') {
              var dets = o[t];
              var ep = dets.loginEndpoint.url;
              url = dets.loginEndpoint.url + '?response_type=token';
              window.swaggerUi.tokenName = dets.tokenName;
                      Severity: Major
                      Found in app/assets/javascripts/grape_swagger_rails/swagger-oauth.js and 1 other location - About 1 hr to fix
                      app/assets/javascripts/grape_swagger_rails/swagger-oauth.js on lines 153..158

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 68.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status