Showing 2 of 10 total issues
Method task_notification has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
def task_notification(task_id, changes, watchers_changes_ids)
@task = Task.find task_id
recipients = ""
@task.watchers.map { |watcher| recipients << "#{watcher.email}, " }
recipients << @task.user.email- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method get_changes_names has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
def get_changes_names(changes)
field = {:responsible_id => User, :status_id => Status, :type_id => ::Type, :estimate_id => Estimate}
field.each do |key , value|
old_name = "None yet"
new_name = "None yet"- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"